You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/12 18:54:43 UTC
[GitHub] [incubator-tvm] tqchen opened a new issue #5792: [RUNTIME] String operator+
tqchen opened a new issue #5792:
URL: https://github.com/apache/incubator-tvm/issues/5792
We have a few places in the code base that uses operator+ of String. Right now:
- we either convert to std string https://github.com/apache/incubator-tvm/blob/master/src/tir/ir/expr.cc#L86
- Or added some overload that converts to std::string https://github.com/apache/incubator-tvm/blob/master/include/tvm/runtime/container.h#L1391
Given that operator+ is quite common, and we can have a better solution in these cases(by allocating the right result length then copy), perhaps we should have a good overload for most cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on issue #5792: [RUNTIME] String operator+
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5792:
URL: https://github.com/apache/incubator-tvm/issues/5792#issuecomment-643433599
cc @zhiics @wweic @junrushao1994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on issue #5792: [RUNTIME][IR] String operator+
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5792:
URL: https://github.com/apache/incubator-tvm/issues/5792#issuecomment-643471539
k, it is mainly about the usability, than the perf aspect
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on issue #5792: [RUNTIME][IR] String operator+
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5792:
URL: https://github.com/apache/incubator-tvm/issues/5792#issuecomment-643703000
@zhiics would you be interested in taking a stab?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on issue #5792: [RUNTIME][IR] String operator+
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on issue #5792:
URL: https://github.com/apache/incubator-tvm/issues/5792#issuecomment-643467187
I agree, not sure about the performance impact though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics edited a comment on issue #5792: [RUNTIME][IR] String operator+
Posted by GitBox <gi...@apache.org>.
zhiics edited a comment on issue #5792:
URL: https://github.com/apache/incubator-tvm/issues/5792#issuecomment-644214755
#5806
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on issue #5792: [RUNTIME][IR] String operator+
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5792:
URL: https://github.com/apache/incubator-tvm/issues/5792#issuecomment-644214755
#5770 5806
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on issue #5792: [RUNTIME][IR] String operator+
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5792:
URL: https://github.com/apache/incubator-tvm/issues/5792#issuecomment-645623251
Closing thanks to @zhiics !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen closed issue #5792: [RUNTIME][IR] String operator+
Posted by GitBox <gi...@apache.org>.
tqchen closed issue #5792:
URL: https://github.com/apache/incubator-tvm/issues/5792
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on issue #5792: [RUNTIME][IR] String operator+
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5792:
URL: https://github.com/apache/incubator-tvm/issues/5792#issuecomment-643687235
Besides this, I think we should make the comparison operators free functions instead of member functions because they are not communicative.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org