[GitHub] spark pull request #16947: [SPARK-19617][SS]Fix the race condition when star...

[zsxwing <gi...@git.apache.org>]

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16947#discussion_r101602345
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala ---
    @@ -250,53 +249,56 @@ class StreamExecution(
           updateStatusMessage("Initializing sources")
           // force initialization of the logical plan so that the sources can be created
           logicalPlan
    -      state = ACTIVE
    -      // Unblock `awaitInitialization`
    -      initializationLatch.countDown()
    -
    -      triggerExecutor.execute(() => {
    -        startTrigger()
    -
    -        val isTerminated =
    -          if (isActive) {
    -            reportTimeTaken("triggerExecution") {
    -              if (currentBatchId < 0) {
    -                // We'll do this initialization only once
    -                populateStartOffsets()
    -                logDebug(s"Stream running from $committedOffsets to $availableOffsets")
    -              } else {
    -                constructNextBatch()
    +      if (state.compareAndSet(INITIALIZING, ACTIVE)) {
    --- End diff --
    
    Most changes here are space changes. You can use https://github.com/apache/spark/pull/16947/files?w=1 to review it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org