You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/23 17:07:04 UTC

[GitHub] [incubator-tvm] leandron commented on pull request #6536: [tvmc] linting error on onnx command line driver frontend

leandron commented on pull request #6536:
URL: https://github.com/apache/incubator-tvm/pull/6536#issuecomment-697710473


   > From the ONNX package `load` is for backward compatibility. Is there any particular reason to change to `load_model`?
   Yeah, looking at it again, it makes sense to come back to `load`. Will revert it.
   
   > Also, pylint E1101 is `no-member`. I assume the reason you want to disable it in along with the change is because of the out-of-date lint file
   This is the main reason for this PR. If I get a fresh clone from github and run `./docker/bash.sh tlcpack/ci-lint:v0.62 ./tests/scripts/task_lint.sh`, I can see a pylint E1101, which seems correct.
   
   > Does that also imply it would be safer to use the compatible API?
   Will move it back.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org