[jira] [Commented] (PDFBOX-4046) Interrupt does not interrupt loading of a PDF

["Tilman Hausherr (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303399#comment-16303399 ] 

Tilman Hausherr commented on PDFBOX-4046:
-----------------------------------------

Maybe we should do this 
https://docs.oracle.com/javase/tutorial/essential/concurrency/interrupt.html
{code}
if (Thread.interrupted())
{
    throw new InterruptedException();
}
{code}
Howevver I wonder if this would make things slower. Usually the loading of files isn't slow... it's the rendering.

> Interrupt does not interrupt loading of a PDF
> ---------------------------------------------
>
>                 Key: PDFBOX-4046
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4046
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Parsing
>    Affects Versions: 2.0.8
>            Reporter: Olivier Cailloux
>            Priority: Minor
>
> PDDocument.load can take quite some time. It would be nice to be able to interrupt the thread if desired. 
> It is also natural to expect that the method PDDocument.load will cease treatment if the thread gets interrupted, similar to e.g. reading a file using a method from the JDK. 
> This [test class|https://github.com/oliviercailloux/PDF-p/blob/pdf-load-non-interruptible/src/test/java/io/github/oliviercailloux/pdf_number_pages/InterruptPdfLoadTest.java] illustrates the problem (the test is green, the problem is only exhibited in the log): running the test on some big file in.pdf shows that the thread goes to the end, even if it takes several seconds more than the time it gets interrupted.
> The companion class {{InterruptReadTest.java}} shows the expected interruption behavior, by contrast, using a normal file read from the JDK: the read stops (almost) as soon as the thread gets interrupted.
> I suppose the same can be said about save, although I have not tested it in detail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org