You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2019/10/08 11:19:54 UTC

[kudu-CR] [rebalance] fix comments

Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14386


Change subject: [rebalance] fix comments
......................................................................

[rebalance] fix comments

Change-Id: I1a384c977ce77375a6e2ec8bf10e2d5c74682585
---
M src/kudu/rebalance/placement_policy_util.cc
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/14386/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a384c977ce77375a6e2ec8bf10e2d5c74682585
Gerrit-Change-Number: 14386
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>

[kudu-CR] [rebalance] fix comments

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14386 )

Change subject: [rebalance] fix comments
......................................................................

[rebalance] fix comments

Change-Id: I1a384c977ce77375a6e2ec8bf10e2d5c74682585
Reviewed-on: http://gerrit.cloudera.org:8080/14386
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/rebalance/placement_policy_util.cc
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a384c977ce77375a6e2ec8bf10e2d5c74682585
Gerrit-Change-Number: 14386
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [rebalance] fix comments

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14386 )

Change subject: [rebalance] fix comments
......................................................................


Patch Set 1: Verified+1

Unrelated test failures in:
  * org.apache.kudu.client.TestKuduClient
  * kudu-admin-test.7


-- 
To view, visit http://gerrit.cloudera.org:8080/14386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a384c977ce77375a6e2ec8bf10e2d5c74682585
Gerrit-Change-Number: 14386
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Oct 2019 14:45:03 +0000
Gerrit-HasComments: No

[kudu-CR] [rebalance] fix comments

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [rebalance] fix comments
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/14386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1a384c977ce77375a6e2ec8bf10e2d5c74682585
Gerrit-Change-Number: 14386
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [rebalance] fix comments

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14386 )

Change subject: [rebalance] fix comments
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a384c977ce77375a6e2ec8bf10e2d5c74682585
Gerrit-Change-Number: 14386
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Oct 2019 14:45:06 +0000
Gerrit-HasComments: No