You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/30 14:22:50 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #8518:
[FLINK-12564][network] Remove getBufferProvider method from
ResultPartitionWriter
zhijiangW commented on a change in pull request #8518: [FLINK-12564][network] Remove getBufferProvider method from ResultPartitionWriter
URL: https://github.com/apache/flink/pull/8518#discussion_r289011719
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java
##########
@@ -188,7 +190,7 @@ public int getNumberOfSubpartitions() {
return subpartitions.length;
}
- @Override
+ @VisibleForTesting
public BufferProvider getBufferProvider() {
Review comment:
It could not be package private, but we could remove it to use `getBufferPool` instead. I could submit a fixup for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services