[GitHub] [spark] HyukjinKwon commented on issue #25098: [SPARK-28280][SQL][PYTHON][TESTS] Convert and port 'group-by.sql' into UDF test base

[GitBox <gi...@apache.org>]

HyukjinKwon commented on issue #25098: [SPARK-28280][SQL][PYTHON][TESTS] Convert and port 'group-by.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25098#issuecomment-510283330
 
 
   Yes, there is the difference about that. I noted it here - https://github.com/apache/spark/pull/25069#issue-295163903
   
   Making it compatible might be one solution because we're not testing Scala's `toString` vs Python's `str` conversion. Optionally, I was also thinking about adding other UDFs of other types that just pass as are. I am not sure yet which way is better.
   
   Another way is that we explicitly wrap it with `CAST` if it's possible to work around by that. I used this way for now but if that's impossible, yes we should fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org