[GitHub] [spark] HyukjinKwon commented on a change in pull request #34036: [SPARK-36795][SQL] - Explain Formatted has Duplicate Node IDs

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #34036:
URL: https://github.com/apache/spark/pull/34036#discussion_r711844803



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ExplainUtils.scala
##########
@@ -148,9 +148,10 @@ object ExplainUtils extends AdaptiveSparkPlanHelper {
         setOpId(p)
       case other: QueryPlan[_] =>
         setOpId(other)
-        other.innerChildren.foldLeft(currentOperationID) {
+        currentOperationID = other.innerChildren.foldLeft(currentOperationID) {
           (curId, plan) => generateOperatorIDs(plan, curId)
         }
+        ()

Review comment:
       why do we need this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org