You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/05 05:34:50 UTC
Review Request: Removed protobuf from mesos, use libprocess protobuf instead.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9744/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
Part 2 of the fix for MESOS-376 (mesos only changes).
This addresses bug MESOS-376.
https://issues.apache.org/jira/browse/MESOS-376
Diffs
-----
src/Makefile.am 851237cbf8db071d27de40c01d702514713b861a
src/examples/python/test-executor.in 457e24f851dc66f1de25f55e292b80e9acab309e
src/examples/python/test-framework.in 88d1e23d2742366f3105025496ae7f7af518a55d
src/python/setup.py.in bb820e29c6aad50982becaea3e431d3ebedec108
third_party/Makefile.am f278485df15271f8b5eacecc268a0fd56124212a
third_party/protobuf-2.4.1.tar.gz 38ec4de504817e266b521b1f79889b8a555e8d5b
third_party/versions.am 69fa794864105c39ef8a39ccfec09315a389e669
Diff: https://reviews.apache.org/r/9744/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Removed protobuf from mesos,
use libprocess protobuf instead.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9744/#review17406
-----------------------------------------------------------
Ship it!
src/python/setup.py.in
<https://reviews.apache.org/r/9744/#comment36929>
Maybe add an 'etc.' after gperftools? Although, I guess protobuf doesn't actually get linked into libprocess ...
- Benjamin Hindman
On March 5, 2013, 4:34 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9744/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 4:34 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Part 2 of the fix for MESOS-376 (mesos only changes).
>
>
> This addresses bug MESOS-376.
> https://issues.apache.org/jira/browse/MESOS-376
>
>
> Diffs
> -----
>
> src/Makefile.am 851237cbf8db071d27de40c01d702514713b861a
> src/examples/python/test-executor.in 457e24f851dc66f1de25f55e292b80e9acab309e
> src/examples/python/test-framework.in 88d1e23d2742366f3105025496ae7f7af518a55d
> src/python/setup.py.in bb820e29c6aad50982becaea3e431d3ebedec108
> third_party/Makefile.am f278485df15271f8b5eacecc268a0fd56124212a
> third_party/protobuf-2.4.1.tar.gz 38ec4de504817e266b521b1f79889b8a555e8d5b
> third_party/versions.am 69fa794864105c39ef8a39ccfec09315a389e669
>
> Diff: https://reviews.apache.org/r/9744/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Removed protobuf from mesos,
use libprocess protobuf instead.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9744/
-----------------------------------------------------------
(Updated March 5, 2013, 8:33 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
benh review
Description
-------
Part 2 of the fix for MESOS-376 (mesos only changes).
This addresses bug MESOS-376.
https://issues.apache.org/jira/browse/MESOS-376
Diffs (updated)
-----
src/Makefile.am 851237cbf8db071d27de40c01d702514713b861a
src/examples/python/test-executor.in 457e24f851dc66f1de25f55e292b80e9acab309e
src/examples/python/test-framework.in 88d1e23d2742366f3105025496ae7f7af518a55d
src/python/setup.py.in bb820e29c6aad50982becaea3e431d3ebedec108
third_party/Makefile.am f278485df15271f8b5eacecc268a0fd56124212a
third_party/protobuf-2.4.1.tar.gz 38ec4de504817e266b521b1f79889b8a555e8d5b
third_party/versions.am 69fa794864105c39ef8a39ccfec09315a389e669
Diff: https://reviews.apache.org/r/9744/diff/
Testing
-------
make check
Thanks,
Ben Mahler