[jira] [Commented] (ARROW-6083) [Java] Refactor Jdbc adapter consume logic

["Ji Liu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904815#comment-16904815 ] 

Ji Liu commented on ARROW-6083:
-------------------------------

[~emkornfield@gmail.com] Thanks for your effort and sorry for always forgetting to specify the module :)

> [Java] Refactor Jdbc adapter consume logic
> ------------------------------------------
>
>                 Key: ARROW-6083
>                 URL: https://issues.apache.org/jira/browse/ARROW-6083
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Java
>            Reporter: Ji Liu
>            Assignee: Ji Liu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.15.0
>
>          Time Spent: 7.5h
>  Remaining Estimate: 0h
>
> Jdbc adapter read from {{ResultSet}} looks like:
> while (rs.next()) {
>  for (int i = 1; i <= columnCount; i++) {
>  jdbcToFieldVector(
>  rs,
>  i,
>  rs.getMetaData().getColumnType(i),
>  rowCount,
>  root.getVector(rsmd.getColumnName(i)),
>  config);
>  }
>  rowCount++;
> }
> And in {{jdbcToFieldVector}} has lots of switch-case, that is to see, for every single value from ResultSet we have to do lots of analyzing conditions.
> I think we could optimize this using consumer/delegate like avro adapter.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)