You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Devaraj Das (JIRA)" <ji...@apache.org> on 2008/12/21 16:38:44 UTC
[jira] Created: (HADOOP-4924) Race condition in re-init of
TaskTracker
Race condition in re-init of TaskTracker
----------------------------------------
Key: HADOOP-4924
URL: https://issues.apache.org/jira/browse/HADOOP-4924
Project: Hadoop Core
Issue Type: Bug
Reporter: Devaraj Das
Assignee: Devaraj Das
Priority: Blocker
Fix For: 0.20.0
The taskReportServer is stopped in the TaskTracker.close() method in a thread. The race condition is:
1) TaskTracker.close() is invoked - this starts a thread to stop the taskReportServer
2) TaskTracker.initialize is invoked - this tries to create a new taskReportServer
Assume that the thread started to stop the taskReportServer gets to start its work after (2) above. The thread will end up stopping the newly created taskReportServer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4924) Race condition in re-init of
TaskTracker
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659200#action_12659200 ]
dhruba borthakur commented on HADOOP-4924:
------------------------------------------
Hi Devaraj, If this affects 0.19 as well, does it need to be commtted into that branch as well?
> Race condition in re-init of TaskTracker
> ----------------------------------------
>
> Key: HADOOP-4924
> URL: https://issues.apache.org/jira/browse/HADOOP-4924
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 4924.patch
>
>
> The taskReportServer is stopped in the TaskTracker.close() method in a thread. The race condition is:
> 1) TaskTracker.close() is invoked - this starts a thread to stop the taskReportServer
> 2) TaskTracker.initialize is invoked - this tries to create a new taskReportServer
> Assume that the thread started to stop the taskReportServer gets to start its work after (2) above. The thread will end up stopping the newly created taskReportServer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4924) Race condition in re-init of
TaskTracker
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659140#action_12659140 ]
dhruba borthakur commented on HADOOP-4924:
------------------------------------------
It would be nice if somebody can comment if this affects 0.17 and 0.18 as well.
> Race condition in re-init of TaskTracker
> ----------------------------------------
>
> Key: HADOOP-4924
> URL: https://issues.apache.org/jira/browse/HADOOP-4924
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 4924.patch
>
>
> The taskReportServer is stopped in the TaskTracker.close() method in a thread. The race condition is:
> 1) TaskTracker.close() is invoked - this starts a thread to stop the taskReportServer
> 2) TaskTracker.initialize is invoked - this tries to create a new taskReportServer
> Assume that the thread started to stop the taskReportServer gets to start its work after (2) above. The thread will end up stopping the newly created taskReportServer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4924) Race condition in re-init of
TaskTracker
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659184#action_12659184 ]
Devaraj Das commented on HADOOP-4924:
-------------------------------------
Yes it does affect those versions as well.
> Race condition in re-init of TaskTracker
> ----------------------------------------
>
> Key: HADOOP-4924
> URL: https://issues.apache.org/jira/browse/HADOOP-4924
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 4924.patch
>
>
> The taskReportServer is stopped in the TaskTracker.close() method in a thread. The race condition is:
> 1) TaskTracker.close() is invoked - this starts a thread to stop the taskReportServer
> 2) TaskTracker.initialize is invoked - this tries to create a new taskReportServer
> Assume that the thread started to stop the taskReportServer gets to start its work after (2) above. The thread will end up stopping the newly created taskReportServer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4924) Race condition in re-init of
TaskTracker
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-4924:
--------------------------------
Status: Patch Available (was: Open)
> Race condition in re-init of TaskTracker
> ----------------------------------------
>
> Key: HADOOP-4924
> URL: https://issues.apache.org/jira/browse/HADOOP-4924
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 4924.patch
>
>
> The taskReportServer is stopped in the TaskTracker.close() method in a thread. The race condition is:
> 1) TaskTracker.close() is invoked - this starts a thread to stop the taskReportServer
> 2) TaskTracker.initialize is invoked - this tries to create a new taskReportServer
> Assume that the thread started to stop the taskReportServer gets to start its work after (2) above. The thread will end up stopping the newly created taskReportServer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4924) Race condition in re-init of
TaskTracker
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-4924:
--------------------------------
Fix Version/s: (was: 0.20.0)
0.19.1
> Race condition in re-init of TaskTracker
> ----------------------------------------
>
> Key: HADOOP-4924
> URL: https://issues.apache.org/jira/browse/HADOOP-4924
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.19.1
>
> Attachments: 4924.patch
>
>
> The taskReportServer is stopped in the TaskTracker.close() method in a thread. The race condition is:
> 1) TaskTracker.close() is invoked - this starts a thread to stop the taskReportServer
> 2) TaskTracker.initialize is invoked - this tries to create a new taskReportServer
> Assume that the thread started to stop the taskReportServer gets to start its work after (2) above. The thread will end up stopping the newly created taskReportServer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4924) Race condition in re-init of
TaskTracker
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659575#action_12659575 ]
dhruba borthakur commented on HADOOP-4924:
------------------------------------------
Thanks Devaraj, for committing this into 0.19.
> Race condition in re-init of TaskTracker
> ----------------------------------------
>
> Key: HADOOP-4924
> URL: https://issues.apache.org/jira/browse/HADOOP-4924
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 4924.patch
>
>
> The taskReportServer is stopped in the TaskTracker.close() method in a thread. The race condition is:
> 1) TaskTracker.close() is invoked - this starts a thread to stop the taskReportServer
> 2) TaskTracker.initialize is invoked - this tries to create a new taskReportServer
> Assume that the thread started to stop the taskReportServer gets to start its work after (2) above. The thread will end up stopping the newly created taskReportServer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4924) Race condition in re-init of
TaskTracker
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-4924:
--------------------------------
Fix Version/s: 0.20.0
> Race condition in re-init of TaskTracker
> ----------------------------------------
>
> Key: HADOOP-4924
> URL: https://issues.apache.org/jira/browse/HADOOP-4924
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.19.1, 0.20.0
>
> Attachments: 4924.patch
>
>
> The taskReportServer is stopped in the TaskTracker.close() method in a thread. The race condition is:
> 1) TaskTracker.close() is invoked - this starts a thread to stop the taskReportServer
> 2) TaskTracker.initialize is invoked - this tries to create a new taskReportServer
> Assume that the thread started to stop the taskReportServer gets to start its work after (2) above. The thread will end up stopping the newly created taskReportServer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4924) Race condition in re-init of
TaskTracker
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-4924:
--------------------------------
Fix Version/s: 0.18.3
I committed this to the 0.18 branch too.
> Race condition in re-init of TaskTracker
> ----------------------------------------
>
> Key: HADOOP-4924
> URL: https://issues.apache.org/jira/browse/HADOOP-4924
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.18.3, 0.19.1, 0.20.0
>
> Attachments: 4924.patch
>
>
> The taskReportServer is stopped in the TaskTracker.close() method in a thread. The race condition is:
> 1) TaskTracker.close() is invoked - this starts a thread to stop the taskReportServer
> 2) TaskTracker.initialize is invoked - this tries to create a new taskReportServer
> Assume that the thread started to stop the taskReportServer gets to start its work after (2) above. The thread will end up stopping the newly created taskReportServer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4924) Race condition in re-init of
TaskTracker
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-4924:
--------------------------------
Attachment: 4924.patch
In the attached patch, I removed the thread doing the taskReportServer.stop(). Instead the TaskTracker.close() stops the taskReportServer inline (this is anyway required for the case where the config for the TaskTracker specifies the RPC port as some non-zero number).
> Race condition in re-init of TaskTracker
> ----------------------------------------
>
> Key: HADOOP-4924
> URL: https://issues.apache.org/jira/browse/HADOOP-4924
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 4924.patch
>
>
> The taskReportServer is stopped in the TaskTracker.close() method in a thread. The race condition is:
> 1) TaskTracker.close() is invoked - this starts a thread to stop the taskReportServer
> 2) TaskTracker.initialize is invoked - this tries to create a new taskReportServer
> Assume that the thread started to stop the taskReportServer gets to start its work after (2) above. The thread will end up stopping the newly created taskReportServer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4924) Race condition in re-init of
TaskTracker
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-4924:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
All tests including test-patch passed on my machine. Committed this.
> Race condition in re-init of TaskTracker
> ----------------------------------------
>
> Key: HADOOP-4924
> URL: https://issues.apache.org/jira/browse/HADOOP-4924
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 4924.patch
>
>
> The taskReportServer is stopped in the TaskTracker.close() method in a thread. The race condition is:
> 1) TaskTracker.close() is invoked - this starts a thread to stop the taskReportServer
> 2) TaskTracker.initialize is invoked - this tries to create a new taskReportServer
> Assume that the thread started to stop the taskReportServer gets to start its work after (2) above. The thread will end up stopping the newly created taskReportServer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4924) Race condition in re-init of
TaskTracker
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659536#action_12659536 ]
Devaraj Das commented on HADOOP-4924:
-------------------------------------
Ok I committed this to 0.19 branch too..
> Race condition in re-init of TaskTracker
> ----------------------------------------
>
> Key: HADOOP-4924
> URL: https://issues.apache.org/jira/browse/HADOOP-4924
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 4924.patch
>
>
> The taskReportServer is stopped in the TaskTracker.close() method in a thread. The race condition is:
> 1) TaskTracker.close() is invoked - this starts a thread to stop the taskReportServer
> 2) TaskTracker.initialize is invoked - this tries to create a new taskReportServer
> Assume that the thread started to stop the taskReportServer gets to start its work after (2) above. The thread will end up stopping the newly created taskReportServer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4924) Race condition in re-init of
TaskTracker
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658458#action_12658458 ]
Arun C Murthy commented on HADOOP-4924:
---------------------------------------
+1
> Race condition in re-init of TaskTracker
> ----------------------------------------
>
> Key: HADOOP-4924
> URL: https://issues.apache.org/jira/browse/HADOOP-4924
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 4924.patch
>
>
> The taskReportServer is stopped in the TaskTracker.close() method in a thread. The race condition is:
> 1) TaskTracker.close() is invoked - this starts a thread to stop the taskReportServer
> 2) TaskTracker.initialize is invoked - this tries to create a new taskReportServer
> Assume that the thread started to stop the taskReportServer gets to start its work after (2) above. The thread will end up stopping the newly created taskReportServer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.