[GitHub] [hadoop] brumi1024 commented on a change in pull request #3858: YARN-10918. Simplify method: CapacitySchedulerQueueManager#parseQueue

[GitBox <gi...@apache.org>]

brumi1024 commented on a change in pull request #3858:
URL: https://github.com/apache/hadoop/pull/3858#discussion_r812097838



##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySchedulerQueueManager.java
##########
@@ -231,99 +229,62 @@ public void reinitializeQueues(CapacitySchedulerConfiguration newConf)
    * @throws IOException
    */
   static CSQueue parseQueue(

Review comment:
       One idea (done it once during YARN-10907, but reverted it when the change was sliced into multiple tickets): AFAIK there is no strong reason why parseQueue is static (apart from saving a few lines of mocking in UTs), but having it static requires two extra parameters (queueContext and conf, both of them are accessible in the class). Maybe we should consider changing it to an instance method. What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org