You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/11/16 13:38:45 UTC
[GitHub] spark pull request #19766: [SPARK-22542][SQL] remove unused features in Colu...
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/19766
[SPARK-22542][SQL] remove unused features in ColumnarBatch
## What changes were proposed in this pull request?
`ColumnarBatch` provides features to do fast filter and project in a columnar fashion, however this feature is never used by Spark, as Spark uses whole stage codegen and processes the data in a row fashion. This PR proposes to remove these unused features as we won't switch to columnar execution in the near future. Even we do, I think this part needs a proper redesign.
This is also a step to make `ColumnVector` public, as we don't wanna expose these features to users.
## How was this patch tested?
existing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark vector
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19766.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19766
----
commit 9cc2def83550c71a5eefd520c9b93f2b5fd5de6a
Author: Wenchen Fan <we...@databricks.com>
Date: 2017-11-16T13:29:58Z
remove unused features in ColumnarBatch
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19766: [SPARK-22542][SQL] remove unused features in ColumnarBat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19766
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83939/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19766: [SPARK-22542][SQL] remove unused features in ColumnarBat...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19766
cc @michal-databricks @gatorsmile @viirya @kiszk
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19766: [SPARK-22542][SQL] remove unused features in ColumnarBat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19766
**[Test build #83939 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83939/testReport)** for PR 19766 at commit [`9cc2def`](https://github.com/apache/spark/commit/9cc2def83550c71a5eefd520c9b93f2b5fd5de6a).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19766: [SPARK-22542][SQL] remove unused features in ColumnarBat...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19766
Thanks! Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19766: [SPARK-22542][SQL] remove unused features in ColumnarBat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19766
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19766: [SPARK-22542][SQL] remove unused features in Colu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19766
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19766: [SPARK-22542][SQL] remove unused features in ColumnarBat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19766
**[Test build #83939 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83939/testReport)** for PR 19766 at commit [`9cc2def`](https://github.com/apache/spark/commit/9cc2def83550c71a5eefd520c9b93f2b5fd5de6a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19766: [SPARK-22542][SQL] remove unused features in ColumnarBat...
Posted by kiszk <gi...@git.apache.org>.
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19766
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org