You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "freemandealer (via GitHub)" <gi...@apache.org> on 2023/06/09 12:38:49 UTC
[GitHub] [doris] freemandealer commented on a diff in pull request #19655: [Refactor](load) Unify streamload BE and FE properties parsing
freemandealer commented on code in PR #19655:
URL: https://github.com/apache/doris/pull/19655#discussion_r1224246177
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/StreamLoadTask.java:
##########
@@ -287,104 +305,104 @@ public static StreamLoadTask fromTStreamLoadPutRequest(TStreamLoadPutRequest req
}
private void setOptionalFromTSLPutRequest(TStreamLoadPutRequest request) throws UserException {
- if (request.isSetColumns()) {
- setColumnToColumnExpr(request.getColumns());
+ if (!Strings.isNullOrEmpty(properties.get(Property.COLUMNS))) {
+ setColumnToColumnExpr(properties.get(Property.COLUMNS));
}
- if (request.isSetWhere()) {
- whereExpr = parseWhereExpr(request.getWhere());
+ if (!Strings.isNullOrEmpty(properties.get(Property.WHERE))) {
+ whereExpr = parseWhereExpr(properties.get(Property.WHERE));
}
- if (request.isSetColumnSeparator()) {
- setColumnSeparator(request.getColumnSeparator());
+ if (!Strings.isNullOrEmpty(properties.get(Property.COLUMN_SEPARATOR))) {
+ setColumnSeparator(properties.get(Property.COLUMN_SEPARATOR));
}
- if (request.isSetLineDelimiter()) {
- setLineDelimiter(request.getLineDelimiter());
+ if (!Strings.isNullOrEmpty(properties.get(Property.LINE_DELIMITER))) {
+ setLineDelimiter(properties.get(Property.LINE_DELIMITER));
}
if (request.isSetHeaderType()) {
headerType = request.getHeaderType();
}
- if (request.isSetPartitions()) {
- String[] partNames = request.getPartitions().trim().split("\\s*,\\s*");
- if (request.isSetIsTempPartition()) {
- partitions = new PartitionNames(request.isIsTempPartition(), Lists.newArrayList(partNames));
+ if (!Strings.isNullOrEmpty(properties.get(Property.PARTITIONS))) {
+ String[] partNames = properties.get(Property.PARTITIONS).trim().split("\\s*,\\s*");
+ if (properties.get(Property.TEMP_PARTITIONS) != null) {
+ partitions = new PartitionNames(true, Lists.newArrayList(partNames));
} else {
partitions = new PartitionNames(false, Lists.newArrayList(partNames));
}
}
switch (request.getFileType()) {
case FILE_STREAM:
- // fall through to case FILE_LOCAL
+ // fall through to case FILE_LOCAL
Review Comment:
unnecessary change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org