You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2023/03/19 23:11:58 UTC

[GitHub] [flink] snuyanzin opened a new pull request, #22216: [FLINK-31516][table] Move execution logic of LoadModule and UnloadModule operations out from TableEnvironmentImpl

snuyanzin opened a new pull request, #22216:
URL: https://github.com/apache/flink/pull/22216

   The PR continues the work started at https://github.com/apache/flink/pull/22175
   
   This PR does this for `LoadModule` and `UnloadModule`.
   
   ## What is the purpose of the change
   
   Migrate `LoadModule` and `UnloadModule`s to extend ExecutableOperation and move it's execution logic  out from TableEnvironmentImpl.
   
   ## Brief change log
   
   Migrate `LoadModule` and `UnloadModule`s to extend ExecutableOperation and move it's execution logic  out from TableEnvironmentImpl.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): ( no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
     - The S3 file system connector: ( no )
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] snuyanzin merged pull request #22216: [FLINK-31516][table] Move execution logic of LoadModule and UnloadModule operations out from TableEnvironmentImpl

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #22216:
URL: https://github.com/apache/flink/pull/22216


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] snuyanzin commented on pull request #22216: [FLINK-31516][table] Move execution logic of LoadModule and UnloadModule operations out from TableEnvironmentImpl

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #22216:
URL: https://github.com/apache/flink/pull/22216#issuecomment-1478976499

   thanks
   
   rebased, to solve conflicts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22216: [FLINK-31516][table] Move execution logic of LoadModule and UnloadModule operations out from TableEnvironmentImpl

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22216:
URL: https://github.com/apache/flink/pull/22216#issuecomment-1475430970

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "76c6f52041ab3247b957913125a218f8b3f4627f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "76c6f52041ab3247b957913125a218f8b3f4627f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 76c6f52041ab3247b957913125a218f8b3f4627f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org