You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/05/11 11:52:08 UTC
[GitHub] [incubator-ratis] runzhiwang opened a new pull request #97: RATIS-935. Fix memory leak by ungister metrics
runzhiwang opened a new pull request #97:
URL: https://github.com/apache/incubator-ratis/pull/97
We need to unregister metrics when close or stop, otherwise memory leak.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] avijayanhwx commented on pull request #97: RATIS-935. Fix memory leak by ungister metrics
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #97:
URL: https://github.com/apache/incubator-ratis/pull/97#issuecomment-636120153
cc @bshashikant / @lokeshj1703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] bshashikant commented on pull request #97: RATIS-935. Fix memory leak by ungister metrics
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #97:
URL: https://github.com/apache/incubator-ratis/pull/97#issuecomment-637408982
thanks @runzhiwang for working on this and @avijayanhwx for the review. I have committed this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang edited a comment on pull request #97: RATIS-935. Fix memory leak by ungister metrics
Posted by GitBox <gi...@apache.org>.
runzhiwang edited a comment on pull request #97:
URL: https://github.com/apache/incubator-ratis/pull/97#issuecomment-626658259
@bshashikant @avijayanhwx Could you help review this patch ?
I think `GrpcServerMetrics `and `LogServiceMetricsRegistry `should extend `RatisMetrics`, then we do not need to define `register `and `unregister `in `GrpcServerMetrics `and `LogServiceMetricsRegistry`. If you agree, I will open another PR to refactor code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang edited a comment on pull request #97: RATIS-935. Fix memory leak by ungister metrics
Posted by GitBox <gi...@apache.org>.
runzhiwang edited a comment on pull request #97:
URL: https://github.com/apache/incubator-ratis/pull/97#issuecomment-626658259
@bshashikant @avijayanhwx Could you help review this patch ?
I think `GrpcServerMetrics `and `LogServiceMetricsRegistry `should extend `RatisMetrics`, then we do not need to define register and unregister in GrpcServerMetrics and LogServiceMetricsRegistry. If you agree, I will open another PR to refactor code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] bshashikant edited a comment on pull request #97: RATIS-935. Fix memory leak by ungister metrics
Posted by GitBox <gi...@apache.org>.
bshashikant edited a comment on pull request #97:
URL: https://github.com/apache/incubator-ratis/pull/97#issuecomment-637408982
Thanks @runzhiwang for working on this and @avijayanhwx for the review. I have committed this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #97: RATIS-935. Fix memory leak by ungister metrics
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #97:
URL: https://github.com/apache/incubator-ratis/pull/97#issuecomment-626658259
@avijayanhwx Could you help review this patch ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang edited a comment on pull request #97: RATIS-935. Fix memory leak by ungister metrics
Posted by GitBox <gi...@apache.org>.
runzhiwang edited a comment on pull request #97:
URL: https://github.com/apache/incubator-ratis/pull/97#issuecomment-626658259
@bshashikant @avijayanhwx Could you help review this patch ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] bshashikant merged pull request #97: RATIS-935. Fix memory leak by ungister metrics
Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #97:
URL: https://github.com/apache/incubator-ratis/pull/97
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] avijayanhwx commented on pull request #97: RATIS-935. Fix memory leak by ungister metrics
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #97:
URL: https://github.com/apache/incubator-ratis/pull/97#issuecomment-630457569
Thank you for the patch @runzhiwang . LGTM +1 (non-binding)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang edited a comment on pull request #97: RATIS-935. Fix memory leak by ungister metrics
Posted by GitBox <gi...@apache.org>.
runzhiwang edited a comment on pull request #97:
URL: https://github.com/apache/incubator-ratis/pull/97#issuecomment-626658259
@bshashikant @avijayanhwx Could you help review this patch ?
I think `GrpcServerMetrics `and `LogServiceMetricsRegistry `should extend `RatisMetrics`, then we do not need to define register and unregister in `GrpcServerMetrics `and `LogServiceMetricsRegistry`. If you agree, I will open another PR to refactor code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org