You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/30 15:28:13 UTC
[GitHub] [tvm] ekalda opened a new pull request #9815: [microNPU] Enable the codegen tests for 256 mac Arm(R) Ethos(TM)-U65 NPU
ekalda opened a new pull request #9815:
URL: https://github.com/apache/tvm/pull/9815
This patch has necessary changes to the Makefile and test
infra to run the FVP based codegen tests on a newer NPU variant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on a change in pull request #9815: [microNPU] Enable the codegen tests for 256 mac Arm(R) Ethos(TM)-U65 NPU
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on a change in pull request #9815:
URL: https://github.com/apache/tvm/pull/9815#discussion_r778050018
##########
File path: tests/python/contrib/test_ethosu/infra.py
##########
@@ -193,6 +193,7 @@ def create_test_runner(accel="ethos-u55-256"):
file_dir = os.path.dirname(os.path.abspath(__file__))
test_root = os.path.join(file_dir, "reference_system")
ethosu_macs = accel[accel.rfind("-") + 1 :]
+ ethosu_variant = accel[accel.find("-") + 1 : -4].upper()
Review comment:
Feel free to ignore, just thought this might be slightly clearer :)
```suggestion
_, ethosu_variant, ethosu_macs = accel.split("-")
ethosu_variant = ethosu_variant.upper()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius merged pull request #9815: [microNPU] Enable the codegen tests for 256 mac Arm(R) Ethos(TM)-U65 NPU
Posted by GitBox <gi...@apache.org>.
Mousius merged pull request #9815:
URL: https://github.com/apache/tvm/pull/9815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ekalda commented on pull request #9815: [microNPU] Enable the codegen tests for 256 mac Arm(R) Ethos(TM)-U65 NPU
Posted by GitBox <gi...@apache.org>.
ekalda commented on pull request #9815:
URL: https://github.com/apache/tvm/pull/9815#issuecomment-1003076749
cc: @manupa-arm @grant-arm @lhutton1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ekalda commented on a change in pull request #9815: [microNPU] Enable the codegen tests for 256 mac Arm(R) Ethos(TM)-U65 NPU
Posted by GitBox <gi...@apache.org>.
ekalda commented on a change in pull request #9815:
URL: https://github.com/apache/tvm/pull/9815#discussion_r778073462
##########
File path: tests/python/contrib/test_ethosu/infra.py
##########
@@ -193,6 +193,7 @@ def create_test_runner(accel="ethos-u55-256"):
file_dir = os.path.dirname(os.path.abspath(__file__))
test_root = os.path.join(file_dir, "reference_system")
ethosu_macs = accel[accel.rfind("-") + 1 :]
+ ethosu_variant = accel[accel.find("-") + 1 : -4].upper()
Review comment:
Yes, that looks much nicer, I'll change it in the next patch, thanks @lhutton1!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ekalda commented on pull request #9815: [microNPU] Enable the codegen tests for 256 mac Arm(R) Ethos(TM)-U65 NPU
Posted by GitBox <gi...@apache.org>.
ekalda commented on pull request #9815:
URL: https://github.com/apache/tvm/pull/9815#issuecomment-1004803406
The CI failed because the upstream CI docker image has not yet absorbed the changes to the FVP and driver version, so this PR can't progress before https://github.com/apache/tvm/issues/9762 is complete...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on a change in pull request #9815: [microNPU] Enable the codegen tests for 256 mac Arm(R) Ethos(TM)-U65 NPU
Posted by GitBox <gi...@apache.org>.
Mousius commented on a change in pull request #9815:
URL: https://github.com/apache/tvm/pull/9815#discussion_r776775243
##########
File path: tests/python/relay/aot/corstone300.mk
##########
@@ -24,8 +24,16 @@ CRT_ROOT ?= ${TVM_ROOT}/build/standalone_crt
ifeq ($(shell ls -lhd $(CRT_ROOT)),)
$(error "CRT not found. Ensure you have built the standalone_crt target and try again")
endif
+
FVP_DIR ?= /opt/arm/FVP_Corstone_SSE-300_Ethos-U55/models/Linux64_GCC-6.4/
+NPU_MACS ?= 256
+
+MODEL = FVP_Corstone_SSE-300_Ethos-U55
+ifeq (${NPU_VARIANT}, U65)
+MODEL = FVP_Corstone_SSE-300_Ethos-U65
+endif
Review comment:
Could this just append the variant?
```suggestion
NPU_MACS ?= 256
NPU_VARIANT ?= U55
MODEL = FVP_Corstone_SSE-300_Ethos-$(NPU_VARIANT)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ekalda commented on a change in pull request #9815: [microNPU] Enable the codegen tests for 256 mac Arm(R) Ethos(TM)-U65 NPU
Posted by GitBox <gi...@apache.org>.
ekalda commented on a change in pull request #9815:
URL: https://github.com/apache/tvm/pull/9815#discussion_r778072899
##########
File path: tests/python/relay/aot/corstone300.mk
##########
@@ -24,8 +24,16 @@ CRT_ROOT ?= ${TVM_ROOT}/build/standalone_crt
ifeq ($(shell ls -lhd $(CRT_ROOT)),)
$(error "CRT not found. Ensure you have built the standalone_crt target and try again")
endif
+
FVP_DIR ?= /opt/arm/FVP_Corstone_SSE-300_Ethos-U55/models/Linux64_GCC-6.4/
+NPU_MACS ?= 256
+
+MODEL = FVP_Corstone_SSE-300_Ethos-U55
+ifeq (${NPU_VARIANT}, U65)
+MODEL = FVP_Corstone_SSE-300_Ethos-U65
+endif
Review comment:
Thanks for the suggestion @Mousius, that makes much more sense indeed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org