You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/10/23 21:50:33 UTC
[GitHub] [trafficcontrol] dpham692 opened a new issue #5188: Message on TP does not display when update Delivery Service
dpham692 opened a new issue #5188:
URL: https://github.com/apache/trafficcontrol/issues/5188
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
- For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
-->
## I'm submitting a ...
<!-- delete all those that don't apply -->
<!--- security vulnerability (STOP!! - see above)-->
- bug report
## Traffic Control components affected ...
<!-- delete all those that don't apply -->
- Traffic Portal
## Current behavior:
<!-- Describe how the bug manifests -->
The error message does not display after user assign a Topology to a DS that has Required Capabilities.
## Expected behavior:
<!-- Describe what the behavior would be without the bug -->
The error message should display so user know the DS is updated or not.
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and
include the applicable TC version.
-->
Create a new server capability (and do not assign it to any servers), add it as a required capability to a non-topology-based DS, then try to assign a topology to that DS. The update should be prohibited but the error message does not display.
## Anything else:
<!--
e.g. stacktraces, related issues, suggestions how to fix (feel free to delete
this section)
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp closed issue #5188: TP: error message doesn't display properly when fulfilling an invalid DSR immediately
Posted by GitBox <gi...@apache.org>.
rawlinp closed issue #5188:
URL: https://github.com/apache/trafficcontrol/issues/5188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp edited a comment on issue #5188: TP: error message doesn't display properly when fulfilling an invalid DSR immediately
Posted by GitBox <gi...@apache.org>.
rawlinp edited a comment on issue #5188:
URL: https://github.com/apache/trafficcontrol/issues/5188#issuecomment-715625188
![image](https://user-images.githubusercontent.com/6724053/97060645-3cb59700-1551-11eb-8065-7a97d8d5fcd4.png)
Verified: that is what I see in the chrome dev tools view, so the TO API is properly returning a 400. However, TP is not displaying this error message at the top of the page like it should.
Note: I reproduced this with DSRs enabled (I fulfilled immediately). Without DSRs, the error message displayed properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp edited a comment on issue #5188: TP: error message doesn't display properly when fulfilling an invalid DSR immediately
Posted by GitBox <gi...@apache.org>.
rawlinp edited a comment on issue #5188:
URL: https://github.com/apache/trafficcontrol/issues/5188#issuecomment-715625188
![image](https://user-images.githubusercontent.com/6724053/97060645-3cb59700-1551-11eb-8065-7a97d8d5fcd4.png)
Verified: that is what I see in the chrome dev tools view, so the TO API is properly returning a 400. However, TP is not displaying this error message at the top of the page like it should.
Note: I reproduced this with DSRs enabled. Without DSRs, the error message displayed properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp closed issue #5188: TP: error message doesn't display properly when fulfilling an invalid DSR immediately
Posted by GitBox <gi...@apache.org>.
rawlinp closed issue #5188:
URL: https://github.com/apache/trafficcontrol/issues/5188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on issue #5188: TP: error message doesn't display properly when fulfilling an invalid DSR immediately
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #5188:
URL: https://github.com/apache/trafficcontrol/issues/5188#issuecomment-716859411
This should not be closed yet as a DSR is incorrectly created/completed when the update to the DS fails API validation. reopening.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on issue #5188: TP: error message doesn't display properly when fulfilling an invalid DSR immediately
Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #5188:
URL: https://github.com/apache/trafficcontrol/issues/5188#issuecomment-715625188
![image](https://user-images.githubusercontent.com/6724053/97060645-3cb59700-1551-11eb-8065-7a97d8d5fcd4.png)
Verified: that is what I see in the chrome dev tools view, so the TO API is properly returning a 400. However, TP is not displaying this error message at the top of the page like it should.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org