You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by ke...@apache.org on 2023/07/20 04:39:54 UTC
[dolphinscheduler] 02/02: Fix wrong judgment condition when building parameters of seatunnel task node. (#14594)
This is an automated email from the ASF dual-hosted git repository.
kerwin pushed a commit to branch 3.1.8-prepare
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git
commit 306439cfcdb37ea4998369fcb02c50b17d3e89dc
Author: Kerwin <37...@users.noreply.github.com>
AuthorDate: Thu Jul 20 12:26:10 2023 +0800
Fix wrong judgment condition when building parameters of seatunnel task node. (#14594)
---
.../plugin/task/seatunnel/flink/SeatunnelFlinkTask.java | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkTask.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkTask.java
index b4311aae71..3bc08e3c6c 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkTask.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkTask.java
@@ -43,13 +43,12 @@ public class SeatunnelFlinkTask extends SeatunnelTask {
@Override
public List<String> buildOptions() throws Exception {
List<String> args = super.buildOptions();
- if (!(Objects.isNull(seatunnelParameters.getRunMode())
- && SeatunnelFlinkParameters.RunModeEnum.NONE.equals(seatunnelParameters.getRunMode()))) {
- args.add(
- Objects.isNull(seatunnelParameters.getRunMode())
- ? SeatunnelFlinkParameters.RunModeEnum.RUN.getCommand()
- : seatunnelParameters.getRunMode().getCommand());
+
+ if (Objects.nonNull(seatunnelParameters.getRunMode())
+ && !SeatunnelFlinkParameters.RunModeEnum.NONE.equals(seatunnelParameters.getRunMode())) {
+ args.add(seatunnelParameters.getRunMode().getCommand());
}
+
if (StringUtils.isNotBlank(seatunnelParameters.getOthers())) {
args.add(seatunnelParameters.getOthers());
}