You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/05/10 22:04:11 UTC

[GitHub] [libcloud] Kami commented on pull request #1686: added new connection type

Kami commented on PR #1686:
URL: https://github.com/apache/libcloud/pull/1686#issuecomment-1122932343

   Thanks for the contribution.
   
   Overall the change looks good to me, but I would be good to see the following:
   
   1. I would like to understanding the reasoning / context / use case behind this change
   2. Some tests would be good
   3. If applicable, some documentation would also be good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org