You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/09 15:56:33 UTC
[GitHub] [incubator-superset] karen-pal opened a new pull request #10014: bump pydruid to 0.5.11
karen-pal opened a new pull request #10014:
URL: https://github.com/apache/incubator-superset/pull/10014
### SUMMARY
Bump version of pydruid: 0.5.9 to 0.5.11
Version 0.5.9 causes installation errors with python 3.7 when running `pip install -r requirements-dev.txt`. This is fixed by bumping said version.
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
* Check that superset can now be fresh installed smoothly in 3.7 envs and doesn't cause errors on other envs.
* Should be tested in different python envs with druid datasources to check it doesn't break stuff.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10014: fix: bump pydruid to 0.6.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10014:
URL: https://github.com/apache/incubator-superset/pull/10014#issuecomment-640804020
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10014?src=pr&el=h1) Report
> Merging [#10014](https://codecov.io/gh/apache/incubator-superset/pull/10014?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/91517a56a3bcacd4c8f2dca233d8df248bfca10e&el=desc) will **decrease** coverage by `1.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10014?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10014 +/- ##
==========================================
- Coverage 65.59% 64.06% -1.53%
==========================================
Files 585 583 -2
Lines 31046 31010 -36
Branches 3277 3175 -102
==========================================
- Hits 20364 19868 -496
- Misses 10501 10964 +463
+ Partials 181 178 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.41% <ø> (+0.04%)` | :arrow_up: |
| #python | `67.35% <ø> (-2.64%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10014?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `28.16% <0.00%> (-54.36%)` | :arrow_down: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `86.34% <0.00%> (-2.59%)` | :arrow_down: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `91.80% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.34% <0.00%> (-0.94%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `49.72% <0.00%> (-0.55%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.06% <0.00%> (-0.09%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.28% <0.00%> (-0.02%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [12 more](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10014?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10014?src=pr&el=footer). Last update [91517a5...323ff43](https://codecov.io/gh/apache/incubator-superset/pull/10014?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #10014: fix: bump pydruid to 0.6.0
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #10014:
URL: https://github.com/apache/incubator-superset/pull/10014
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] karen-pal commented on pull request #10014: fix:bump pydruid to 0.5.11
Posted by GitBox <gi...@apache.org>.
karen-pal commented on pull request #10014:
URL: https://github.com/apache/incubator-superset/pull/10014#issuecomment-640815002
> @karen-pal did you try [0.6.0](https://pypi.org/project/pydruid/0.6.0/)? While it doesn't introduce any new features, its requirements are better aligned with the current Superset dependencies. For instance, Pandas is unpinned from the old `0.25` version. See [druid-io/pydruid#219](https://github.com/druid-io/pydruid/pull/219) for a full list of changes.
I haven't, since I don't really use pydruid/druid. I wanted to bump the version to the one that started supporting python3.7 to stop the installation from crashing. I could bump it to 0.6.0 though!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10014: bump pydruid to 0.5.11
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10014:
URL: https://github.com/apache/incubator-superset/pull/10014#issuecomment-640804908
@karen-pal did you try [0.6.0](https://pypi.org/project/pydruid/0.6.0/)? While it doesn't introduce any new features, its requirements are better aligned with the current Superset dependencies. For instance, Pandas is unpinned from the old `0.25` version. See https://github.com/druid-io/pydruid/pull/219 for a full list of changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10014: bump pydruid to 0.5.11
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10014:
URL: https://github.com/apache/incubator-superset/pull/10014#issuecomment-640804020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10014: bump pydruid to 0.5.11
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10014:
URL: https://github.com/apache/incubator-superset/pull/10014#issuecomment-640804020
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10014?src=pr&el=h1) Report
> Merging [#10014](https://codecov.io/gh/apache/incubator-superset/pull/10014?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/91517a56a3bcacd4c8f2dca233d8df248bfca10e&el=desc) will **increase** coverage by `1.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10014?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10014 +/- ##
==========================================
+ Coverage 65.59% 67.02% +1.42%
==========================================
Files 585 184 -401
Lines 31046 18197 -12849
Branches 3277 0 -3277
==========================================
- Hits 20364 12196 -8168
+ Misses 10501 6001 -4500
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `67.02% <ø> (-2.97%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10014?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `28.22% <0.00%> (-54.29%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `86.34% <0.00%> (-2.59%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.96% <0.00%> (-2.34%)` | :arrow_down: |
| ... and [412 more](https://codecov.io/gh/apache/incubator-superset/pull/10014/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10014?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10014?src=pr&el=footer). Last update [91517a5...b49a329](https://codecov.io/gh/apache/incubator-superset/pull/10014?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org