[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #625: Add conditional defaults to TDML properties

["Shanedell (via GitHub)" <gi...@apache.org>]

Shanedell commented on code in PR #625:
URL: https://github.com/apache/daffodil-vscode/pull/625#discussion_r1190326325


##########
src/tests/suite/utils.test.ts:
##########
@@ -35,12 +35,7 @@ suite('Utils Test Suite', () => {
       type: 'none',
       path: '${workspaceFolder}/infoset.xml',
     },
-    tdmlConfig: {
-      action: 'none',
-      name: '${command:AskForTDMLName}',
-      description: '${command:AskForTDMLDescription}',
-      path: '${command:AskForTDMLPath}',
-    },
+    tdmlConfig: null,

Review Comment:
   Remove this line. This will break the testing because you specifically don't add the `tdmlConfig` if the tdml props aren't needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org