You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "William Ferguson (JIRA)" <ji...@codehaus.org> on 2007/07/24 05:25:13 UTC
[jira] Created: (MRELEASE-270) release:prepare doesn't fail when
the project it is building fails to compile
release:prepare doesn't fail when the project it is building fails to compile
-----------------------------------------------------------------------------
Key: MRELEASE-270
URL: http://jira.codehaus.org/browse/MRELEASE-270
Project: Maven 2.x Release Plugin
Issue Type: Bug
Affects Versions: 2.0-beta-6
Reporter: William Ferguson
Attachments: MRELEASE-XXX.zip
Unusual situation on our build server, where one of the dependent libraries had been corrupted in its local repository.
'mvn compile' would fail with compilation errors - it couldn't find the classes from the corrupt jar.
'mvn release:prepare' would note compilation errors and indicate build failure, but would continue on with the release, modify the POMs, tag the source and finally complete indicating success.
I noted that the same thing can happen if uncompilable source is checked in, though at least then you would get the compilation failure on your local machine too.
I think release:prepare should clearly fail (it wasn't clear in this instance unless you scrolled back through the build output) if any part of the release:prepare fails.
To replicate either
a) Attempt top release uncompilable code.
b) Replace a dependent jar with a renamed text file and attempt to release.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-270) release:prepare doesn't fail when
the project it is building fails to compile
Posted by "Julien HENRY (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_103580 ]
Julien HENRY commented on MRELEASE-270:
---------------------------------------
I can confirm.
I ask on the mailing list, and someone said there was a modification of mvn.bat (since 2.0.7) under Windows, which will prevent forked mvn errors to be propagated.
In fact, it should be a maven core bug, not a release plugin bug, but I don't know where it could be reported.
> release:prepare doesn't fail when the project it is building fails to compile
> -----------------------------------------------------------------------------
>
> Key: MRELEASE-270
> URL: http://jira.codehaus.org/browse/MRELEASE-270
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-6
> Reporter: William Ferguson
> Attachments: MRELEASE-XXX.zip
>
>
> Unusual situation on our build server, where one of the dependent libraries had been corrupted in its local repository.
> 'mvn compile' would fail with compilation errors - it couldn't find the classes from the corrupt jar.
> 'mvn release:prepare' would note compilation errors and indicate build failure, but would continue on with the release, modify the POMs, tag the source and finally complete indicating success.
> I noted that the same thing can happen if uncompilable source is checked in, though at least then you would get the compilation failure on your local machine too.
> I think release:prepare should clearly fail (it wasn't clear in this instance unless you scrolled back through the build output) if any part of the release:prepare fails.
> To replicate either
> a) Attempt top release uncompilable code.
> b) Replace a dependent jar with a renamed text file and attempt to release.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-270) release:prepare doesn't fail when
the project it is building fails to compile
Posted by "William Ferguson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_107334 ]
William Ferguson commented on MRELEASE-270:
-------------------------------------------
I have validated that the fix for http://jira.codehaus.org/browse/MNG-3084 in 2.0.8 resolves this issue.
So could someone please close this issue as fixed in Maven 2.0.8
> release:prepare doesn't fail when the project it is building fails to compile
> -----------------------------------------------------------------------------
>
> Key: MRELEASE-270
> URL: http://jira.codehaus.org/browse/MRELEASE-270
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-6
> Reporter: William Ferguson
> Attachments: MRELEASE-XXX.zip
>
>
> Unusual situation on our build server, where one of the dependent libraries had been corrupted in its local repository.
> 'mvn compile' would fail with compilation errors - it couldn't find the classes from the corrupt jar.
> 'mvn release:prepare' would note compilation errors and indicate build failure, but would continue on with the release, modify the POMs, tag the source and finally complete indicating success.
> I noted that the same thing can happen if uncompilable source is checked in, though at least then you would get the compilation failure on your local machine too.
> I think release:prepare should clearly fail (it wasn't clear in this instance unless you scrolled back through the build output) if any part of the release:prepare fails.
> To replicate either
> a) Attempt top release uncompilable code.
> b) Replace a dependent jar with a renamed text file and attempt to release.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-270) release:prepare doesn't fail when
the project it is building fails to compile
Posted by "Stephen Coy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_103445 ]
Stephen Coy commented on MRELEASE-270:
--------------------------------------
We have noticed the same behavior when unit tests fail too.
I think this is a regression in one of the maven components because the same release plugin behaves correctly with maven 2.0.5.
> release:prepare doesn't fail when the project it is building fails to compile
> -----------------------------------------------------------------------------
>
> Key: MRELEASE-270
> URL: http://jira.codehaus.org/browse/MRELEASE-270
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-6
> Reporter: William Ferguson
> Attachments: MRELEASE-XXX.zip
>
>
> Unusual situation on our build server, where one of the dependent libraries had been corrupted in its local repository.
> 'mvn compile' would fail with compilation errors - it couldn't find the classes from the corrupt jar.
> 'mvn release:prepare' would note compilation errors and indicate build failure, but would continue on with the release, modify the POMs, tag the source and finally complete indicating success.
> I noted that the same thing can happen if uncompilable source is checked in, though at least then you would get the compilation failure on your local machine too.
> I think release:prepare should clearly fail (it wasn't clear in this instance unless you scrolled back through the build output) if any part of the release:prepare fails.
> To replicate either
> a) Attempt top release uncompilable code.
> b) Replace a dependent jar with a renamed text file and attempt to release.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-270) release:prepare doesn't fail when
the project it is building fails to compile
Posted by "William Ferguson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_103062 ]
William Ferguson commented on MRELEASE-270:
-------------------------------------------
NB the attached zip contains a project with uncompilable source.
> release:prepare doesn't fail when the project it is building fails to compile
> -----------------------------------------------------------------------------
>
> Key: MRELEASE-270
> URL: http://jira.codehaus.org/browse/MRELEASE-270
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-6
> Reporter: William Ferguson
> Attachments: MRELEASE-XXX.zip
>
>
> Unusual situation on our build server, where one of the dependent libraries had been corrupted in its local repository.
> 'mvn compile' would fail with compilation errors - it couldn't find the classes from the corrupt jar.
> 'mvn release:prepare' would note compilation errors and indicate build failure, but would continue on with the release, modify the POMs, tag the source and finally complete indicating success.
> I noted that the same thing can happen if uncompilable source is checked in, though at least then you would get the compilation failure on your local machine too.
> I think release:prepare should clearly fail (it wasn't clear in this instance unless you scrolled back through the build output) if any part of the release:prepare fails.
> To replicate either
> a) Attempt top release uncompilable code.
> b) Replace a dependent jar with a renamed text file and attempt to release.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MRELEASE-270) release:prepare doesn't fail when the
project it is building fails to compile
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Venisse closed MRELEASE-270.
-------------------------------------
Assignee: Emmanuel Venisse
Resolution: Won't Fix
It isn't a release plugin issue but a maven 2.0.7 issue
> release:prepare doesn't fail when the project it is building fails to compile
> -----------------------------------------------------------------------------
>
> Key: MRELEASE-270
> URL: http://jira.codehaus.org/browse/MRELEASE-270
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-6
> Reporter: William Ferguson
> Assignee: Emmanuel Venisse
> Attachments: MRELEASE-XXX.zip
>
>
> Unusual situation on our build server, where one of the dependent libraries had been corrupted in its local repository.
> 'mvn compile' would fail with compilation errors - it couldn't find the classes from the corrupt jar.
> 'mvn release:prepare' would note compilation errors and indicate build failure, but would continue on with the release, modify the POMs, tag the source and finally complete indicating success.
> I noted that the same thing can happen if uncompilable source is checked in, though at least then you would get the compilation failure on your local machine too.
> I think release:prepare should clearly fail (it wasn't clear in this instance unless you scrolled back through the build output) if any part of the release:prepare fails.
> To replicate either
> a) Attempt top release uncompilable code.
> b) Replace a dependent jar with a renamed text file and attempt to release.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira