You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2021/08/16 02:49:22 UTC

[GitHub] [knox] YunLemon opened a new pull request #482: Shallow cloning on travis

YunLemon opened a new pull request #482:
URL: https://github.com/apache/knox/pull/482


   According to [https://docs.travis-ci.com/user/customizing-the-build#git-clone-depth](url), Travis CI provide a way to shallow clone a repository. This has the obvious benefit of speed, since you only need to download a small number of commits.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [knox] smolnar82 commented on pull request #482: Shallow cloning on travis

Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #482:
URL: https://github.com/apache/knox/pull/482#issuecomment-982393752


   I agree with @pzampino that changing this value does not really bring new benefits (proven by the above-referenced jobs). So let me close this PR for now w/o merging it. Feel free to re-open and convince the Knox community if you think otherwise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [knox] YunLemon commented on pull request #482: Shallow cloning on travis

Posted by GitBox <gi...@apache.org>.
YunLemon commented on pull request #482:
URL: https://github.com/apache/knox/pull/482#issuecomment-899918423


   `depth` doesn't squash commits, instead of cloning the complete repository (as usually done with git), using clone depth just clones the last clone-depth-number revisions of your repository.
   According to [Disadvantages of shallow cloning on Travis and other CI services?](https://stackoverflow.com/questions/31278233/disadvantages-of-shallow-cloning-on-travis-and-other-ci-services), there are two main problems with using shallow clones:
   1. Push too fast. Can you really push so fast?
   2. Restart an old build. Do you have this need?
   For a PR can have more than 3 commits, I don't think `depth` will be an issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [knox] pzampino commented on pull request #482: Shallow cloning on travis

Posted by GitBox <gi...@apache.org>.
pzampino commented on pull request #482:
URL: https://github.com/apache/knox/pull/482#issuecomment-900308678


   Is there any data which shows this improves the Knox Travis CI builds? These builds are already a little flaky, and I would prefer to avoid possibly making them even more flaky, especially if there is no noticeable benefit. Admittedly, this is a git feature with which I am not yet very familiar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [knox] moresandeep commented on a change in pull request #482: Shallow cloning on travis

Posted by GitBox <gi...@apache.org>.
moresandeep commented on a change in pull request #482:
URL: https://github.com/apache/knox/pull/482#discussion_r689803688



##########
File path: .travis.yml
##########
@@ -41,7 +41,7 @@ before_install:
 script:
   - $DOCKERRUN $IMAGE mvn -T.75C clean verify -U -Dshellcheck=true -Dsurefire.useFile=false -Djavax.net.ssl.trustStorePassword=changeit -Dmaven.wagon.http.retryHandler.count=5 -Dmaven.wagon.http.retryHandler.class=default -Dmaven.wagon.http.retryHandler.nonRetryableClasses=java.io.InterruptedIOException -Dhttp.keepAlive=false -B -V
 git:
-  depth: 1000
+  depth: 3

Review comment:
       Do you think we need to increase this to say 5?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [knox] YunLemon commented on pull request #482: Shallow cloning on travis

Posted by GitBox <gi...@apache.org>.
YunLemon commented on pull request #482:
URL: https://github.com/apache/knox/pull/482#issuecomment-901791038


   I compare these two builds [https://app.travis-ci.com/github/apache/knox/jobs/531547372](https://app.travis-ci.com/github/apache/knox/jobs/531547372) and [https://app.travis-ci.com/github/apache/knox/jobs/532288500](https://app.travis-ci.com/github/apache/knox/jobs/532288500). 1.47s vs 2.71s. Although the speed has increased twice, the absolute value is very small.....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [knox] smolnar82 closed pull request #482: Shallow cloning on travis

Posted by GitBox <gi...@apache.org>.
smolnar82 closed pull request #482:
URL: https://github.com/apache/knox/pull/482


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org