You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/15 14:00:00 UTC

[GitHub] [doris] morrySnow opened a new pull request, #10897: [refactor](Nereids)remove generic type from Rule and Job

morrySnow opened a new pull request, #10897:
URL: https://github.com/apache/doris/pull/10897

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   In the past, we use generic type for Rule and Job to support do rule based transform in Memo for both Plan and Expression. But we do not use memo to do expression optimization any more. So generic type is useless for Rule and Job and introduces complexity. so we remove generic type from Rule and Job.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #10897: [refactor](Nereids)remove generic type from Rule and Job

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10897:
URL: https://github.com/apache/doris/pull/10897#issuecomment-1187143633

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman merged pull request #10897: [refactor](Nereids)remove generic type from Rule and Job

Posted by GitBox <gi...@apache.org>.
morningman merged PR #10897:
URL: https://github.com/apache/doris/pull/10897


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #10897: [refactor](Nereids)remove generic type from Rule and Job

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10897:
URL: https://github.com/apache/doris/pull/10897#issuecomment-1186947704

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org