You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/28 05:11:33 UTC
[GitHub] [pulsar] yufan022 opened a new pull request #9070: [docs]add parameter for helm init cluster
yufan022 opened a new pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070
### Motivation
I failed to deploy the pulsar cluster according to the [document](http://pulsar.apache.org/docs/en/kubernetes-helm/#step-2-use-pulsar-admin-to-create-pulsar-tenantsnamespacestopics).
I checked the pulsar-helm [repository](https://github.com/apache/pulsar-helm-chart), need add parameter `--set initialize=true` to initialize the cluster metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yufan022 commented on a change in pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
yufan022 commented on a change in pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#discussion_r549542786
##########
File path: site2/website/versioned_docs/version-2.7.1/getting-started-helm.md
##########
@@ -81,9 +81,14 @@ We use [Minikube](https://kubernetes.io/docs/getting-started-guides/minikube/) i
3. Use the Pulsar Helm chart to install a Pulsar cluster to Kubernetes.
+ > NOTE: Please specify `--set initialize=true` when installing a release at the first time. `initialize=true` will start initialize jobs
+ > to initialize the cluster metadata for both bookkeeper and pulsar clusters.
Review comment:
@Jennifer88huang
You mean change
`NOTE: Please specify --set initialize=true when installing a release at the first time. `initialize=true` will start initialize jobs to initialize the cluster metadata for both bookkeeper and pulsar clusters.`
to
`This command installs and starts Apache Pulsar` ？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#discussion_r549562469
##########
File path: site2/website/versioned_docs/version-2.7.1/getting-started-helm.md
##########
@@ -81,9 +81,14 @@ We use [Minikube](https://kubernetes.io/docs/getting-started-guides/minikube/) i
3. Use the Pulsar Helm chart to install a Pulsar cluster to Kubernetes.
+ > NOTE: Please specify `--set initialize=true` when installing a release at the first time. `initialize=true` will start initialize jobs
+ > to initialize the cluster metadata for both bookkeeper and pulsar clusters.
Review comment:
I mean you can change it into
```
> **NOTE**
> You need to specify `--set initialize=true` when installing Pulsar the first time. This command installs and starts Apache Pulsar.
```
or
```
> **NOTE**
> You need to specify `--set initialize=true` when installing Pulsar the first time. This command initializes the metadata for both BookKeeper and Pulsar clusters.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yufan022 commented on pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
yufan022 commented on pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#issuecomment-752352409
> @yufan022 Great, thank you. The file in main branch is this file https://github.com/apache/pulsar/blob/master/site2/docs/getting-started-helm.md
> Could you apply the changes to this file as well? So it will apply to the next major release (2.8.0). Thank you very much for doing so.
Completed PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#discussion_r549320284
##########
File path: site2/website/versioned_docs/version-2.7.1/getting-started-helm.md
##########
@@ -81,9 +81,14 @@ We use [Minikube](https://kubernetes.io/docs/getting-started-guides/minikube/) i
3. Use the Pulsar Helm chart to install a Pulsar cluster to Kubernetes.
+ > NOTE: Please specify `--set initialize=true` when installing a release at the first time. `initialize=true` will start initialize jobs
+ > to initialize the cluster metadata for both bookkeeper and pulsar clusters.
Review comment:
> **NOTE**
> You need to specify `--set initialize=true` when installing Pulsar the first time. Setting `initialize=true` starts initializing jobs to initialize the cluster metadata for both BookKeeper and Pulsar clusters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yufan022 commented on pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
yufan022 commented on pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#issuecomment-751732918
> @yufan022 Thank you very much for your contribution. Does the change apply only to 2.7.1?
@Jennifer88huang Maybe more versions, It depends on the version of Helm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yufan022 edited a comment on pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
yufan022 edited a comment on pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#issuecomment-751732918
> @yufan022 Thank you very much for your contribution. Does the change apply only to 2.7.1?
@Jennifer88huang Maybe more versions, It depends on the version of Helm.
It is committed on the 14 Aug.
https://github.com/apache/pulsar-helm-chart/commit/b44b523c8a14255d6939c355130ae7f6e8fdb749
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang merged pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
Jennifer88huang merged pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#issuecomment-751687114
@yufan022 Thank you very much for your contribution. Does the change apply only to 2.7.1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#issuecomment-752382311
@yufan022 Thank you very much for your contribution~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#issuecomment-751911824
@@yufan022 Thanks for your info. From this commit "apache/pulsar-helm-chart@b44b523", we can see that it affects versions since 2.6.1. Could you please apply the changes to 2.6.1, 2.6.2, 2.6.3, 2.7.0 and the main branch as well? Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yufan022 edited a comment on pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
yufan022 edited a comment on pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#issuecomment-751732918
> @yufan022 Thank you very much for your contribution. Does the change apply only to 2.7.1?
@Jennifer88huang Maybe more versions, It depends on the version of Helm. It is committed on the 14 Aug.
https://github.com/apache/pulsar-helm-chart/commit/b44b523c8a14255d6939c355130ae7f6e8fdb749
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#issuecomment-752103854
@yufan022 Great, thank you. The file in main branch is this file https://github.com/apache/pulsar/blob/master/site2/docs/getting-started-helm.md
Could you apply the changes to this file as well? So it will apply to the next major release (2.8.0). Thank you very much for doing so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yufan022 commented on pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
yufan022 commented on pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#issuecomment-751979451
@Jennifer88huang Hi, some new commits. Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#discussion_r549320456
##########
File path: site2/website/versioned_docs/version-2.7.1/getting-started-helm.md
##########
@@ -81,9 +81,14 @@ We use [Minikube](https://kubernetes.io/docs/getting-started-guides/minikube/) i
3. Use the Pulsar Helm chart to install a Pulsar cluster to Kubernetes.
+ > NOTE: Please specify `--set initialize=true` when installing a release at the first time. `initialize=true` will start initialize jobs
+ > to initialize the cluster metadata for both bookkeeper and pulsar clusters.
Review comment:
When you write "starts initializing jobs to initialize", do you mean "Setting `initialize=true` starts initializing the cluster metadata....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#discussion_r549533291
##########
File path: site2/website/versioned_docs/version-2.7.1/getting-started-helm.md
##########
@@ -81,9 +81,14 @@ We use [Minikube](https://kubernetes.io/docs/getting-started-guides/minikube/) i
3. Use the Pulsar Helm chart to install a Pulsar cluster to Kubernetes.
+ > NOTE: Please specify `--set initialize=true` when installing a release at the first time. `initialize=true` will start initialize jobs
+ > to initialize the cluster metadata for both bookkeeper and pulsar clusters.
Review comment:
@yufan022 Thanks for your reference. I think "This command installs and starts Apache Pulsar" is clear and concise. Maybe it's better to use this one. If you want to add BK, you can refine it as "This command initializes the metadata for both BookKeeper and Pulsar clusters."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yufan022 commented on a change in pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
yufan022 commented on a change in pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#discussion_r549367042
##########
File path: site2/website/versioned_docs/version-2.7.1/getting-started-helm.md
##########
@@ -81,9 +81,14 @@ We use [Minikube](https://kubernetes.io/docs/getting-started-guides/minikube/) i
3. Use the Pulsar Helm chart to install a Pulsar cluster to Kubernetes.
+ > NOTE: Please specify `--set initialize=true` when installing a release at the first time. `initialize=true` will start initialize jobs
+ > to initialize the cluster metadata for both bookkeeper and pulsar clusters.
Review comment:
Reference from https://github.com/apache/pulsar-helm-chart
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yufan022 commented on a change in pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
yufan022 commented on a change in pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#discussion_r549542786
##########
File path: site2/website/versioned_docs/version-2.7.1/getting-started-helm.md
##########
@@ -81,9 +81,14 @@ We use [Minikube](https://kubernetes.io/docs/getting-started-guides/minikube/) i
3. Use the Pulsar Helm chart to install a Pulsar cluster to Kubernetes.
+ > NOTE: Please specify `--set initialize=true` when installing a release at the first time. `initialize=true` will start initialize jobs
+ > to initialize the cluster metadata for both bookkeeper and pulsar clusters.
Review comment:
You mean change
`NOTE: Please specify --set initialize=true when installing a release at the first time. `initialize=true` will start initialize jobs to initialize the cluster metadata for both bookkeeper and pulsar clusters.`
to
`This command installs and starts Apache Pulsar` ？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yufan022 edited a comment on pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
yufan022 edited a comment on pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#issuecomment-751732918
> @yufan022 Thank you very much for your contribution. Does the change apply only to 2.7.1?
@Jennifer88huang Maybe more versions, It depends on the version of Helm. Committed by 14 Aug.
https://github.com/apache/pulsar-helm-chart/commit/b44b523c8a14255d6939c355130ae7f6e8fdb749
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yufan022 edited a comment on pull request #9070: [docs]add parameter for helm init cluster
Posted by GitBox <gi...@apache.org>.
yufan022 edited a comment on pull request #9070:
URL: https://github.com/apache/pulsar/pull/9070#issuecomment-751732918
> @yufan022 Thank you very much for your contribution. Does the change apply only to 2.7.1?
@Jennifer88huang Maybe more versions, It depends on the version of pulsar-helm. Committed by 14 Aug.
https://github.com/apache/pulsar-helm-chart/commit/b44b523c8a14255d6939c355130ae7f6e8fdb749
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org