You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Reid Chan (Jira)" <ji...@apache.org> on 2019/08/23 11:05:00 UTC

[jira] [Commented] (HBASE-22904) NPE occurs when RS send space quota usage report during HMaster init

    [ https://issues.apache.org/jira/browse/HBASE-22904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914177#comment-16914177 ] 

Reid Chan commented on HBASE-22904:
-----------------------------------

Nice catch!

I have one thought, for discussion, about the fix, what about including QuotaManager in master's initialization check. That means after {{master.checkInitialized()}}, {{QuotaManager}} can't be null.

(I'm just not a fan of null check)

> NPE occurs when RS send space quota usage report during HMaster init
> --------------------------------------------------------------------
>
>                 Key: HBASE-22904
>                 URL: https://issues.apache.org/jira/browse/HBASE-22904
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Pankaj Kumar
>            Assignee: Pankaj Kumar
>            Priority: Minor
>
> During HMaster failover, if RegionServer send space quota report to HMaster and MasterQuotaManager is not yet initialized then NPE will occur.
> https://github.com/apache/hbase/blob/767bb1511285ae67dae15e8a2aab62c38244c797/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java#L2229



--
This message was sent by Atlassian Jira
(v8.3.2#803003)