You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "jaykay12 (via GitHub)" <gi...@apache.org> on 2026/10/16 21:41:28 UTC
[PR] SOLR-16396: Migrate remaining GET /config/{component} sections to JAX-RS [solr]
jaykay12 opened a new pull request, #5174:
URL: https://github.com/apache/solr/pull/5174
https://issues.apache.org/jira/browse/SOLR-16396
# Description
Migrate remaining GET /config/{component} sections to JAX-RS
# Solution
This will be a follow-up PR after: https://github.com/apache/solr/pull/5168 lands on main.
Will convert this from Draft -> ready-for-review once that PR is merged.
With this PR merged, all GET config sections will get be fully JAX-RS compatible.
# Tests
TBA
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
- [x] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-16396: Migrate remaining GET /config/{component} sections to JAX-RS [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #5174:
URL: https://github.com/apache/solr/pull/5174#issuecomment-6245038369
Found a bug while reviewing this against \`dev-docs/apis-v2-conventions.adoc\`: \`circuitBreaker\`, \`initParams\`, \`listener\`, and \`updateRequestProcessorChain\` are declared without \`REQUIRE_NAME\` in \`SolrConfig\`'s plugin registry, so \`SolrConfig#writeMap\` serializes them as a \`List\` rather than a name-keyed \`Map\`. \`GetConfig#filterByComponentName\`'s unconditional \`(Map)\` cast then throws a \`ClassCastException\` for any by-name lookup against these sections — reachable both via v1's \`componentName\` query param (pre-existing bug, predates this PR) and the new v2 \`GET /config/{component}/{componentName}\` path this PR adds. That surfaces as an uncaught 500 instead of the documented NOT_FOUND/404 convention.
Reproduced with a throwaway test: \`GET .../config/circuitBreaker/x\` 500'd with the ClassCastException before this fix, returns a clean 404 after.
Pushed a fix:
- \`filterByComponentName\` now checks the section's shape and throws a clean \`NOT_FOUND\` when by-name filtering doesn't apply (fixes the v1 path too).
- Dropped those 4 non-named sections from the v2 by-name \`@Path\` regex, since a route that can never match by name isn't useful API surface.
- Also noticed \`cache\` has the same \`REQUIRE_NAME + MULTI_OK\` shape as the other sections this PR already pluralizes (\`listener\`→\`listeners\`, \`queryParser\`→\`queryParsers\`, etc.) but was left singular — renamed to \`caches\` for consistency.
All existing tests pass (\`GetConfigTest\`, \`GetConfigSolrCloudTest\`, \`V2ConfigAPIMappingTest\`, \`TestSolrConfigHandler\`, \`TestSolrConfigHandlerCloud\`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-16396: Migrate remaining GET /config/{component} sections to JAX-RS [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #5174:
URL: https://github.com/apache/solr/pull/5174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-16396: Migrate remaining GET /config/{component} sections to JAX-RS [solr]
Posted by "jaykay12 (via GitHub)" <gi...@apache.org>.
jaykay12 commented on PR #5174:
URL: https://github.com/apache/solr/pull/5174#issuecomment-6295297048
## Testing
Few V2 APIs
link|test screenshot
---|---
http://localhost:8983/api/collections/techproducts/config/luceneMatchVersion|<img width="776" height="251" alt="Screenshot 2026-10-20 at 9 09 17 PM" src="https://github.com/user-attachments/assets/213ae97d-c894-4a54-bfde-23deabaebbba" />
http://localhost:8983/api/collections/techproducts/config/initParams|<img width="765" height="316" alt="Screenshot 2026-10-20 at 9 10 42 PM" src="https://github.com/user-attachments/assets/6e9c0785-f609-4ba4-bb40-9791a662186f" />
http://localhost:8983/api/collections/techproducts/config/listeners|<img width="782" height="380" alt="Screenshot 2026-10-20 at 9 11 14 PM" src="https://github.com/user-attachments/assets/f9788707-82f9-428d-9bf7-2ed9be1175ad" />
http://localhost:8983/api/collections/techproducts/config/requestDispatcher|<img width="767" height="332" alt="Screenshot 2026-10-20 at 9 11 46 PM" src="https://github.com/user-attachments/assets/23dc9d0d-b647-424a-bb79-47dfca52737b" />
Remaining others, i couldn't find for the "techproducts" example that i was using in local testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org