[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #11988: [Java Client] Make Audience Field Optional in OAuth2 Client Credentials

[GitBox <gi...@apache.org>]

BewareMyPower commented on code in PR #11988:
URL: https://github.com/apache/pulsar/pull/11988#discussion_r859452803


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/auth/oauth2/protocol/TokenClient.java:
##########
@@ -73,10 +73,21 @@ public void close() throws Exception {
 
     /**
      * Constructing http request parameters.
-     * @param bodyMap List of parameters to be requested.
+     * @param req object with relevant request parameters
      * @return Generate the final request body from a map.
      */
-    String buildClientCredentialsBody(Map<String, String> bodyMap) {
+    String buildClientCredentialsBody(ClientCredentialsExchangeRequest req) {
+        Map<String, String> bodyMap = new TreeMap<>();

Review Comment:
   Could you explain why do you use a `TreeMap` here? I'm not sure if the order makes a difference.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org