You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/05/11 14:48:09 UTC

[jira] [Commented] (THRIFT-3143) add typescript directory support

    [ https://issues.apache.org/jira/browse/THRIFT-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537894#comment-14537894 ] 

ASF GitHub Bot commented on THRIFT-3143:
----------------------------------------

GitHub user wilfrem opened a pull request:

    https://github.com/apache/thrift/pull/488

    THRIFT-3143

    Current typescript support is only work for browser, and generated d.ts uses internal module.
    So, it's hard to use for typescript in node.js.
    
    To solve probrem, generate typescript code directory.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wilfrem/thrift THRIFT-3143

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/488.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #488
    
----
commit b7d008c7e8bd565850d4bc1be48c77eb1cac19b9
Author: wilfrem <wi...@gmail.com>
Date:   2015-04-20T10:24:50Z

    copy from t_js_generator.cc to t_ts_generator.cc and minimal modify for passing build

commit 60566e2b54d595731894e13cb6b34dd515dd039f
Author: wilfrem <wi...@gmail.com>
Date:   2015-04-20T11:13:55Z

    fix enum/const/namespace

commit 05971859bd20dd9740a938c230071db6ae0b941b
Author: wilfrem <wi...@gmail.com>
Date:   2015-04-20T13:13:28Z

    implement struct

commit e9f2e5ed079130e306df37c9550744335918f5ef
Author: wilfrem <wi...@gmail.com>
Date:   2015-04-21T07:22:48Z

    implement all things left

commit 7687fbd9f4d4a1eecb368404561cc46c2641e24a
Author: wilfrem <wi...@gmail.com>
Date:   2015-04-22T10:12:20Z

    fix to pass compile

commit ac1ea84d93228b39eca9d4393627b8f783d56d03
Author: wilfrem <wi...@gmail.com>
Date:   2015-04-22T12:58:05Z

    bugfix

commit bc3537e3d8a91b648308ab741c2156e3db60b2b6
Author: wilfrem <wi...@gmail.com>
Date:   2015-05-08T05:36:21Z

    bugfix

commit ed7c4a3028cd9897ae9379181f3f2146be0b78f8
Author: wilfrem <wi...@gmail.com>
Date:   2015-05-08T07:04:45Z

    bugfix

commit 14e5d0740fbf15cf94f1c9c11072bf4be0fde368
Author: wilfrem <wi...@gmail.com>
Date:   2015-05-11T05:42:22Z

    bugfix

commit 730ff83f75f4123b166d2313e56c27280608fe35
Author: wilfrem <wi...@gmail.com>
Date:   2015-05-11T09:54:33Z

    add test for node-typescript

----


> add typescript directory support
> --------------------------------
>
>                 Key: THRIFT-3143
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3143
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Node.js - Compiler
>            Reporter: Kazuki Yasufuku
>
> Current typescript support is only work for browser, and generated d.ts uses internal module.
> So, it's hard to use for typescript in node.js.
> To solve probrem, I make a pull request that generate typescript code directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)