You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@auron.apache.org by "Tartarus0zm (via GitHub)" <gi...@apache.org> on 2025/10/27 10:29:28 UTC
[PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Tartarus0zm opened a new pull request, #1532:
URL: https://github.com/apache/auron/pull/1532
<!--
Thanks for sending a pull request! Please keep the following tips in mind:
- Start the PR title with the related issue ID, e.g. '[AURON #XXXX] Short summary...'.
- Make your PR title clear and descriptive, summarizing what this PR changes.
- Provide a concise example to reproduce the issue, if possible.
- Keep the PR description up to date with all changes.
-->
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1531.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Enable SparkAuronConfiguration and deprecated AuronConf
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
# How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Posted by "ShreyeshArangath (via GitHub)" <gi...@apache.org>.
ShreyeshArangath commented on code in PR #1532:
URL: https://github.com/apache/auron/pull/1532#discussion_r2469815814
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/SparkUDTFWrapperContext.scala:
##########
@@ -58,8 +62,11 @@ case class SparkUDTFWrapperContext(serialized: ByteBuffer) extends Logging {
}
private val tc = TaskContext.get()
- private val batchSize = AuronConf.BATCH_SIZE.intConf()
- private val maxBatchMemorySize = AuronConf.SUGGESTED_BATCH_MEM_SIZE.intConf()
+ private val sparkAuronConfig: AuronConfiguration =
Review Comment:
Should this be a method on AuronAdaptor? All the invocations of the adaptor to get the configuration requests a `getInstance` call; we can abstract this away by adding `getSparkAuronConfig()` as a public method in the Adaptor, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Posted by "Tartarus0zm (via GitHub)" <gi...@apache.org>.
Tartarus0zm commented on PR #1532:
URL: https://github.com/apache/auron/pull/1532#issuecomment-3460400231
> @Tartarus0zm, you'd better to improve the description of this pull request. Current description is too simple.
@SteNicholas Thanks for the reminder. I have updated the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Posted by "Tartarus0zm (via GitHub)" <gi...@apache.org>.
Tartarus0zm commented on code in PR #1532:
URL: https://github.com/apache/auron/pull/1532#discussion_r2471581642
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/SparkUDTFWrapperContext.scala:
##########
@@ -58,8 +62,11 @@ case class SparkUDTFWrapperContext(serialized: ByteBuffer) extends Logging {
}
private val tc = TaskContext.get()
- private val batchSize = AuronConf.BATCH_SIZE.intConf()
- private val maxBatchMemorySize = AuronConf.SUGGESTED_BATCH_MEM_SIZE.intConf()
+ private val sparkAuronConfig: AuronConfiguration =
Review Comment:
> Should this be a method on AuronAdaptor? All the invocations of the adaptor to get the configuration requests a `getInstance` call; we can abstract this away by adding `getSparkAuronConfig()` as a public method in the Adaptor, WDYT?
@ShreyeshArangath thanks for your comment. This is an excellent suggestion. I suggest we open a separate issue to discuss this. We introduced the AuronAdaptor to abstract away specific engines like Spark, Flink, and Trino, so the API does not carry the engine name. Let's discuss this issue in #1535.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #1532:
URL: https://github.com/apache/auron/pull/1532#discussion_r2471647566
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala:
##########
@@ -1192,9 +1202,8 @@ object NativeConverters extends Logging {
.setInputSchema(NativeConverters.convertSchema(paramsSchema)))
aggBuilder.addAllChildren(convertedChildren.keys.asJava)
} else {
- throw new NotImplementedError(
- s"unsupported aggregate expression: (${e.getClass})," +
- s" set ${AuronConf.UDAF_FALLBACK_ENABLE.key} true to enable UDAF fallbacking")
+ throw new NotImplementedError(s"unsupported aggregate expression: (${e.getClass})," +
+ s" set ${SparkAuronConfiguration.UDAF_FALLBACK_ENABLE.key} true to enable UDAF fallbacking")
Review Comment:
```suggestion
s" set ${SparkAuronConfiguration.UDAF_FALLBACK_ENABLE.key} to true to enable UDAF fallbacking.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1532:
URL: https://github.com/apache/auron/pull/1532#discussion_r2468096647
##########
spark-extension/src/main/java/org/apache/spark/sql/auron/AuronConf.java:
##########
@@ -19,6 +19,10 @@
import org.apache.spark.SparkConf;
import org.apache.spark.SparkEnv$;
+/**
+ * This class has been deprecated and migrated to {@link org.apache.auron.spark.configuration.SparkAuronConfiguration}.
Review Comment:
Add `@Deprecated` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Posted by "Tartarus0zm (via GitHub)" <gi...@apache.org>.
Tartarus0zm commented on code in PR #1532:
URL: https://github.com/apache/auron/pull/1532#discussion_r2472167042
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala:
##########
@@ -140,6 +143,10 @@ object AuronConverters extends Logging {
getBooleanConf("spark.auron.enable.shuffleExchange", defaultValue = true)
private val extConvertProviders = ServiceLoader.load(classOf[AuronConvertProvider]).asScala
+
+ private val sparkAuronConfig: AuronConfiguration =
+ AuronAdaptor.getInstance.getAuronConfiguration
Review Comment:
@SteNicholas The API `getAuronConfiguration` already exists within the `AuronAdaptor`. Since the `AuronAdaptor ` use the singleton pattern, the `getInstance` API must be called first each time.
Let's discuss this issue in https://github.com/apache/auron/issues/1535.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Posted by "Tartarus0zm (via GitHub)" <gi...@apache.org>.
Tartarus0zm commented on code in PR #1532:
URL: https://github.com/apache/auron/pull/1532#discussion_r2468115899
##########
spark-extension/src/main/java/org/apache/spark/sql/auron/AuronConf.java:
##########
@@ -19,6 +19,10 @@
import org.apache.spark.SparkConf;
import org.apache.spark.SparkEnv$;
+/**
+ * This class has been deprecated and migrated to {@link org.apache.auron.spark.configuration.SparkAuronConfiguration}.
Review Comment:
good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #1532:
URL: https://github.com/apache/auron/pull/1532#issuecomment-3459499104
@Tartarus0zm, you'd better to improve the description of this pull request. Current description is too simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Posted by "Tartarus0zm (via GitHub)" <gi...@apache.org>.
Tartarus0zm commented on code in PR #1532:
URL: https://github.com/apache/auron/pull/1532#discussion_r2472242807
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala:
##########
@@ -1192,9 +1202,8 @@ object NativeConverters extends Logging {
.setInputSchema(NativeConverters.convertSchema(paramsSchema)))
aggBuilder.addAllChildren(convertedChildren.keys.asJava)
} else {
- throw new NotImplementedError(
- s"unsupported aggregate expression: (${e.getClass})," +
- s" set ${AuronConf.UDAF_FALLBACK_ENABLE.key} true to enable UDAF fallbacking")
+ throw new NotImplementedError(s"unsupported aggregate expression: (${e.getClass})," +
Review Comment:
I have Updated. PTAL
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala:
##########
@@ -1192,9 +1202,8 @@ object NativeConverters extends Logging {
.setInputSchema(NativeConverters.convertSchema(paramsSchema)))
aggBuilder.addAllChildren(convertedChildren.keys.asJava)
} else {
- throw new NotImplementedError(
- s"unsupported aggregate expression: (${e.getClass})," +
- s" set ${AuronConf.UDAF_FALLBACK_ENABLE.key} true to enable UDAF fallbacking")
+ throw new NotImplementedError(s"unsupported aggregate expression: (${e.getClass})," +
+ s" set ${SparkAuronConfiguration.UDAF_FALLBACK_ENABLE.key} true to enable UDAF fallbacking")
Review Comment:
I have Updated. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #1532:
URL: https://github.com/apache/auron/pull/1532#discussion_r2471646278
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala:
##########
@@ -1192,9 +1202,8 @@ object NativeConverters extends Logging {
.setInputSchema(NativeConverters.convertSchema(paramsSchema)))
aggBuilder.addAllChildren(convertedChildren.keys.asJava)
} else {
- throw new NotImplementedError(
- s"unsupported aggregate expression: (${e.getClass})," +
- s" set ${AuronConf.UDAF_FALLBACK_ENABLE.key} true to enable UDAF fallbacking")
+ throw new NotImplementedError(s"unsupported aggregate expression: (${e.getClass})," +
Review Comment:
```suggestion
throw new NotImplementedError(s"Unsupported aggregate expression: (${e.getClass})," +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Posted by "Tartarus0zm (via GitHub)" <gi...@apache.org>.
Tartarus0zm commented on PR #1532:
URL: https://github.com/apache/auron/pull/1532#issuecomment-3451001696
@richox @merrily01 CI is green. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Posted by "Tartarus0zm (via GitHub)" <gi...@apache.org>.
Tartarus0zm commented on code in PR #1532:
URL: https://github.com/apache/auron/pull/1532#discussion_r2468478413
##########
spark-extension/src/main/java/org/apache/spark/sql/auron/AuronConf.java:
##########
@@ -19,6 +19,10 @@
import org.apache.spark.SparkConf;
import org.apache.spark.SparkEnv$;
+/**
+ * This class has been deprecated and migrated to {@link org.apache.auron.spark.configuration.SparkAuronConfiguration}.
Review Comment:
> Add `@Deprecated` ?
@cxzl25 I have updated the PR. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #1532:
URL: https://github.com/apache/auron/pull/1532#discussion_r2471648637
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala:
##########
@@ -140,6 +143,10 @@ object AuronConverters extends Logging {
getBooleanConf("spark.auron.enable.shuffleExchange", defaultValue = true)
private val extConvertProviders = ServiceLoader.load(classOf[AuronConvertProvider]).asScala
+
+ private val sparkAuronConfig: AuronConfiguration =
+ AuronAdaptor.getInstance.getAuronConfiguration
Review Comment:
Could we add `getAuronConfiguration` in `AuronAdaptor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1531] Enable SparkAuronConfiguration and deprecated AuronConf [auron]
Posted by "richox (via GitHub)" <gi...@apache.org>.
richox merged PR #1532:
URL: https://github.com/apache/auron/pull/1532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org