You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2017/03/20 17:18:10 UTC
[GitHub] activemq-artemis pull request #1108: ARTEMIS-1051 Make ServerSession send th...
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1108
ARTEMIS-1051 Make ServerSession send thread safe
According to @clebertsuconic this is a historical design decision when the CORE protocol was the main focus. With Proton and AMQP it is possible that sends are initiated from separate threads, this could cause problem when a send on a single server session is interleaved with 2 threads.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1051
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1108
----
commit 0122ca05153778f30e3089389cd47251240dbade
Author: Martyn Taylor <mt...@redhat.com>
Date: 2017-03-20T17:16:10Z
ARTEMIS-1051 Make ServerSession send thread safe
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1108: ARTEMIS-1051 Make ServerSession send thread sa...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1108
@clebertsuconic Sure, I'll update accordingly. I am a little confused on your previous comment, are you just saying that we've already added locks, so shouldn't be too much of a problem or does your previous comment re: "adding locks" mean you found one?
I'll update here and run the full suite. Cheers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1108: ARTEMIS-1051 Make ServerSession send thread sa...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1108
@clebertsuconic check the patch. I wasn't entirely sure what you were asking for. I've made the send method thread safe using the object monitor (i.e. synchronized) vs the original patch which created a separate send lock.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1108: ARTEMIS-1051 Make ServerSession send thread sa...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1108
/me running tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1108: ARTEMIS-1051 Make ServerSession send th...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1108: ARTEMIS-1051 Make ServerSession send thread sa...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1108
I told you to be careful with adding locks, but looking at the code now, xaStart, xaCommit are made synchronized for the same reason. (It was a case about reconnects and reattachs).
Can you just make send to be synchronized send.. same with sendTX?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---