[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #381: HDDS-2781. Add ObjectID and updateID to BucketInfo to avoid replaying transactions

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #381: HDDS-2781. Add ObjectID and updateID to BucketInfo to avoid replaying transactions
URL: https://github.com/apache/hadoop-ozone/pull/381#discussion_r361206564
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketDeleteRequest.java
 ##########
 @@ -135,12 +151,16 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
           DeleteBucketResponse.newBuilder().build());
 
       // Add to double buffer.
-      omClientResponse = new OMBucketDeleteResponse(volumeName, bucketName,
-          omResponse.build());
+      omClientResponse = new OMBucketDeleteResponse(omResponse.build(),
+          volumeName, bucketName);
+      LOG.debug("Deleted bucket:{} in volume:{}", bucketName, volumeName);
     } catch (IOException ex) {
+      omMetrics.incNumBucketDeleteFails();
+      LOG.error("Delete bucket failed for bucket:{} in volume:{}", bucketName,
 
 Review comment:
   Can we move back logging to before?
   
   Why that is done like that way is, logging to be done outside the lock.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org