You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/11/19 02:20:01 UTC
[GitHub] [incubator-gobblin] codecov-io commented on issue #2818:
[GOBBLIN-963] Remove duplicated copies of TaskContext/TaskState when
constructing TaskIFaceWrapper
codecov-io commented on issue #2818: [GOBBLIN-963] Remove duplicated copies of TaskContext/TaskState when constructing TaskIFaceWrapper
URL: https://github.com/apache/incubator-gobblin/pull/2818#issuecomment-555301108
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2818?src=pr&el=h1) Report
> Merging [#2818](https://codecov.io/gh/apache/incubator-gobblin/pull/2818?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/e24bc26a28434bfee9ea4926e1b7d59901e63ec8?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2818 +/- ##
============================================
+ Coverage 45.56% 45.57% +<.01%
- Complexity 8954 8955 +1
============================================
Files 1900 1900
Lines 71213 71213
Branches 7856 7856
============================================
+ Hits 32451 32454 +3
+ Misses 35780 35772 -8
- Partials 2982 2987 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2818?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/gobblin/runtime/GobblinMultiTaskAttempt.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2818/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvR29iYmxpbk11bHRpVGFza0F0dGVtcHQuamF2YQ==) | `56.3% <80%> (ø)` | `27 <0> (ø)` | :arrow_down: |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2818/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `92.85% <0%> (-7.15%)` | `4% <0%> (ø)` | |
| [...ava/org/apache/gobblin/fsm/FiniteStateMachine.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2818/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZzbS9GaW5pdGVTdGF0ZU1hY2hpbmUuamF2YQ==) | `73.48% <0%> (-3.04%)` | `18% <0%> (-3%)` | |
| [...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2818/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==) | `15.68% <0%> (+0.84%)` | `4% <0%> (+1%)` | :arrow_up: |
| [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2818/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=) | `64.44% <0%> (+1.11%)` | `16% <0%> (+1%)` | :arrow_up: |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2818/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `39.25% <0%> (+3.73%)` | `13% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2818?src=pr&el=footer). Last update [e24bc26...479f397](https://codecov.io/gh/apache/incubator-gobblin/pull/2818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services