You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/03/17 06:36:30 UTC
[GitHub] [dubbo-go] wenxuwan opened a new pull request #1088: upgrade hession version
wenxuwan opened a new pull request #1088:
URL: https://github.com/apache/dubbo-go/pull/1088
**What this PR does**:
Upgrade go-hession version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] wongoo commented on a change in pull request #1088: upgrade hession version
Posted by GitBox <gi...@apache.org>.
wongoo commented on a change in pull request #1088:
URL: https://github.com/apache/dubbo-go/pull/1088#discussion_r595748841
##########
File path: go.sum
##########
@@ -117,6 +117,8 @@ github.com/apache/dubbo-go-hessian2 v1.8.2 h1:CQq2Mmlrk6Fqmudwl9Dqps8drTrBFnmXRl
github.com/apache/dubbo-go-hessian2 v1.8.2/go.mod h1:xQUjE7F8PX49nm80kChFvepA/AvqAZ0oh/UaB6+6pBE=
Review comment:
these history can be deleted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #1088: upgrade hession version
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1088:
URL: https://github.com/apache/dubbo-go/pull/1088#issuecomment-800850081
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1088?src=pr&el=h1) Report
> Merging [#1088](https://codecov.io/gh/apache/dubbo-go/pull/1088?src=pr&el=desc) (9f359d0) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/968650f658b63c11bb0409897d29c57b91cfaf50?el=desc) (968650f) will **decrease** coverage by `0.52%`.
> The diff coverage is `60.26%`.
> :exclamation: Current head 9f359d0 differs from pull request most recent head 15db1fc. Consider uploading reports for the commit 15db1fc to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1088?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #1088 +/- ##
==========================================
- Coverage 59.53% 59.01% -0.53%
==========================================
Files 259 269 +10
Lines 12737 13123 +386
==========================================
+ Hits 7583 7744 +161
- Misses 4199 4410 +211
- Partials 955 969 +14
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1088?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/available\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1088/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYXZhaWxhYmxlX2NsdXN0ZXIuZ28=) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/zone\_aware\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1088/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvem9uZV9hd2FyZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `64.28% <ø> (ø)` | |
| [cluster/router/healthcheck/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1088/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZmFjdG9yeS5nbw==) | `66.66% <0.00%> (ø)` | |
| [cluster/router/tag/router\_rule.go](https://codecov.io/gh/apache/dubbo-go/pull/1088/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3JvdXRlcl9ydWxlLmdv) | `89.47% <ø> (+12.20%)` | :arrow_up: |
| [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/1088/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
| [common/extension/conn\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/1088/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25uX2NoZWNrZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1088/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/1088/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <0.00%> (+0.22%)` | :arrow_up: |
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1088/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.02% <ø> (ø)` | |
| [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1088/diff?src=pr&el=tree#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `54.28% <0.00%> (ø)` | |
| ... and [173 more](https://codecov.io/gh/apache/dubbo-go/pull/1088/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1088?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1088?src=pr&el=footer). Last update [6f74ff9...15db1fc](https://codecov.io/gh/apache/dubbo-go/pull/1088?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] wenxuwan commented on a change in pull request #1088: upgrade hession version
Posted by GitBox <gi...@apache.org>.
wenxuwan commented on a change in pull request #1088:
URL: https://github.com/apache/dubbo-go/pull/1088#discussion_r595757283
##########
File path: go.sum
##########
@@ -117,6 +117,8 @@ github.com/apache/dubbo-go-hessian2 v1.8.2 h1:CQq2Mmlrk6Fqmudwl9Dqps8drTrBFnmXRl
github.com/apache/dubbo-go-hessian2 v1.8.2/go.mod h1:xQUjE7F8PX49nm80kChFvepA/AvqAZ0oh/UaB6+6pBE=
Review comment:
done, by the way, why we need delete these history ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cityiron merged pull request #1088: upgrade hession version
Posted by GitBox <gi...@apache.org>.
cityiron merged pull request #1088:
URL: https://github.com/apache/dubbo-go/pull/1088
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org