You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "pvillard31 (via GitHub)" <gi...@apache.org> on 2024/10/22 21:03:48 UTC
[PR] NIFI-13904 - Fix CLI commands to set/remove parameter context inheritance [nifi]
pvillard31 opened a new pull request, #9437:
URL: https://github.com/apache/nifi/pull/9437
# Summary
[NIFI-13904](https://issues.apache.org/jira/browse/NIFI-13904) - Linking Parameter Contexts using NiFi Toolkit causes sensitive parameters to become invalid
The current implementation of the CLI for setting / removing the parameter context inheritance is broken when the parameter context to update contains sensitive parameters. The reason is that, currently, the update parameter request is adding all of the parameter entities in the request. However, when we retrieve sensitive parameters, we never really retrieve the sensitive values on the client side, we only get `*****` strings. Because of this, the update request needs to be updated so that the value of the sensitive parameters is explicitly set to `null` so that the backend knows that the sensitive parameters are not changed by this update request.
This pull request also slightly improves the display output of parameters retrieved via a parameter provider. I'm happy to put this into a separate PR if we think this is better. While reproducing the issue, I noticed that the command to fetch parameters from a parameter provider is not giving information about the created parameter contexts so this additional information can be useful and removes the need for listing parameter contexts.
Example:
````
./bin/cli.sh nifi fetch-params -p nifi-cli.properties -ppid b56a9960-0192-1000-b4f7-33908ea4027f --sensitiveParamPattern ".*ensitive.*" --applyParameters
Property Name Property Value
--------------------------- ------------------------------------------------------
parameter-group-directories /Users/pierre/dev/nifi_use_cases/NIFI-13904/parameters
parameter-value-byte-limit 256 B
parameter-value-encoding plaintext
Parameter Group Parameter Context Id Parameter Context Name Fetched Parameter Name
--------------- ------------------------------------ ---------------------- ----------------------
parameters b56e3ce7-0192-1000-65fd-1ce89d329bbe parameters myParameter
parameters b56e3ce7-0192-1000-65fd-1ce89d329bbe parameters mySensitiveParameter
````
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13904 - Fix CLI commands to set/remove parameter context inheritance [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory merged PR #9437:
URL: https://github.com/apache/nifi/pull/9437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org