You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ddoaj97 (via GitHub)" <gi...@apache.org> on 2023/04/19 08:31:55 UTC

[GitHub] [camel-karavan] ddoaj97 opened a new issue, #730: Editing of components with multiple path properties doesn't work correctly

ddoaj97 opened a new issue, #730:
URL: https://github.com/apache/camel-karavan/issues/730

   Many Camel component have more than one path parameter and currently the visual Karavan editor doesn't seem to handle these components very well. For example the Quartz component URI syntax is defined as  "quartz:groupName/triggerName" and contains two path parameters: "groupName" and "triggerName". Trying to configure these path properties in Karavan generates an incorrect URI because Karavan seems to mix up the two path properties.
   
   Trying to enter the value "test" in the "Group name" input field of the Quartz component causes Karavan to generate the following URI:
   ![karavan_uri_path_bug_quartz](https://user-images.githubusercontent.com/17296796/233015685-4ba062e5-1724-4bfd-8146-1de839d141b4.PNG)
   
   It seems like the first character of the "Group name" gets parsed into the "Trigger name" field and only the remaining characters end up in the "Group name" field. The problem disappears once both input fields have value, but as soon as you clear the group name and enter a new value, then the same issue occurs again.
   
   **I've tried other components that have multiple path properties (activemq, jms, rest, ftp, imap, ...) and they all have the same problem.**
   
   Components with more than 2 path properties seem to be even more buggy. For example the "springws" component has 4 path properties and is completely unuseable. Trying to enter the value "expression" into the "Expression" input field seems to duplicate this value multiple times into the "Web Service Endpoint Uri" input field:
   ![karavan_uri_path_bug_springws](https://user-images.githubusercontent.com/17296796/233016014-fad0f3ce-0df2-4247-8156-70e2f8443824.PNG)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] LeeyCul commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "LeeyCul (via GitHub)" <gi...@apache.org>.
LeeyCul commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1553882875

   I tried and I don't know how to get started,Can you prioritize handling this bug?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] ddoaj97 commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "ddoaj97 (via GitHub)" <gi...@apache.org>.
ddoaj97 commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1514575227

   Hi Claus,
   
   Yes, you are correct. I am using Karavan release 3.20.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] mgubaidullin commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1587232770

   @LeeyCul could you please provide an example of component that has an issue with configuration? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] davsclaus commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1514358156

   Thanks for reporting, and I assume you are using latest 3.20.1 release of karavan


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] mgubaidullin closed issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin closed issue #730: Editing of components with multiple path properties doesn't work correctly
URL: https://github.com/apache/camel-karavan/issues/730


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] LeeyCul commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "LeeyCul (via GitHub)" <gi...@apache.org>.
LeeyCul commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1598472692

   The correct value should be direct:rest1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] LeeyCul commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "LeeyCul (via GitHub)" <gi...@apache.org>.
LeeyCul commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1544983900

   Has this bug been unsolved yet
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] mgubaidullin commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1589959534

   @davsclaus  to avoid all complexity you mentioned above, I'm planning to remove URI parser and generator in Karavan and set path parameters  same way as query parameters, ex:
   
   ```
   - route:
       id: route-e06b
       from:
         uri: timer
         id: from-74ea
         parameters:
           timerName: timer1
         steps:
           - to:
               uri: activemq
               id: to-c229
               parameters:
                 destinationType: topic
                 destinationName: topic1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] LeeyCul commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "LeeyCul (via GitHub)" <gi...@apache.org>.
LeeyCul commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1594333812

   @mgubaidullin Will version 3.20.2 remain unchanged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] mgubaidullin closed issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin closed issue #730: Editing of components with multiple path properties doesn't work correctly
URL: https://github.com/apache/camel-karavan/issues/730


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] LeeyCul commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "LeeyCul (via GitHub)" <gi...@apache.org>.
LeeyCul commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1544993173

   It would be great if it could be repaired in a timely manner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] davsclaus commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1546119691

   This is more complex to resolve as its only a handful of camel components that have multiple paths, and building correct URIs is more tricky. There is code in pure java we use internally in Camel itself. But that code is big and a big ugly. However for karavan such kind of code may need to be ported to typescript.
   
   ASF is open community and users are very welcome to help with the project. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] LeeyCul commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "LeeyCul (via GitHub)" <gi...@apache.org>.
LeeyCul commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1588356860

   @mgubaidullin 
   When I create a new REST,
   <img width="1094" alt="image" src="https://github.com/apache/camel-karavan/assets/31834149/22226958-1f80-4047-8680-a47aed4dea5e">
   <img width="483" alt="image" src="https://github.com/apache/camel-karavan/assets/31834149/7537d612-eff6-4a8e-8d82-dbf56aeadfe3">
   Will directly cause issues with the uri address


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] LeeyCul commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "LeeyCul (via GitHub)" <gi...@apache.org>.
LeeyCul commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1598471313

   https://github.com/apache/camel-karavan/issues/730#issuecomment-1589959534
   After following this modification, new issues have emerged:
   Two new Directs have been created, named rest1 and rest2 respectively,Incorrect URI selection address after switching to REST new interface
   <img width="1510" alt="image" src="https://github.com/apache/camel-karavan/assets/31834149/b2861bad-1a4f-4d33-8c7a-edc772c66ba6">
   <img width="1500" alt="image" src="https://github.com/apache/camel-karavan/assets/31834149/f9127bad-174a-48ba-b7d2-9f6713c85ac8">
   @mgubaidullin 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] mgubaidullin commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1581612649

   @davsclaus could you please take a look https://issues.apache.org/jira/browse/CAMEL-19426


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] LeeyCul commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "LeeyCul (via GitHub)" <gi...@apache.org>.
LeeyCul commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1586778249

   This seems like there's no solution at all. 
   // if (result.at(result.length - 1) === '') return result.slice(0, -2).join(''); // remove last colon
   This just looks like the configuration is fine, but after switching the code, new issues will appear, with inconsistencies on both sides
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-karavan] mgubaidullin commented on issue #730: Editing of components with multiple path properties doesn't work correctly

Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #730:
URL: https://github.com/apache/camel-karavan/issues/730#issuecomment-1594485275

   @LeeyCul 3.20.2 comes with unified path and query parameters. Karavan will continue to read and parse path parameters from uri, but write only as key: value 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org