[GitHub] [helix] kaisun2000 commented on a change in pull request #1580: Update the internal fields of the Data Providr when overriding the data through set methods.

[GitBox <gi...@apache.org>]

kaisun2000 commented on a change in pull request #1580:
URL: https://github.com/apache/helix/pull/1580#discussion_r539696247



##########
File path: helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java
##########
@@ -384,8 +384,8 @@ public synchronized void refresh(HelixDataAccessor accessor) {
     _instanceMessagesCache.updateRelayMessages(_liveInstanceCache.getPropertyMap(),
         _currentStateCache.getParticipantStatesMap());
 
-    updateIdealRuleMap();
-    updateDisabledInstances();
+    updateIdealRuleMap(getClusterConfig());

Review comment:
       why here we use getClusterConfig() while later in `setClusterConfig` we use _clusterConfig?
   
   In fact, 
   
   ```
     public ClusterConfig getClusterConfig() {
       return _clusterConfig;
     }
   ```
   
   any specific reason?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org