You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:57:31 UTC

[GitHub] [incubator-superset] kkucharc commented on a change in pull request #11525: fix: extended droppable area on the top of dashboards

kkucharc commented on a change in pull request #11525:
URL: https://github.com/apache/incubator-superset/pull/11525#discussion_r516528654



##########
File path: superset-frontend/src/dashboard/stylesheets/dnd.less
##########
@@ -123,7 +129,8 @@
   }
 
   & > .empty-droptarget:first-child {
-    height: 24px;
+    height: 48px;

Review comment:
       This is really good idea. But unfortunately it might not be that easy, because we would have to detect if first row is placed and dynamically change height of the `droptarget` element to limit back the area above first row. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org