[GitHub] rhtyd commented on a change in pull request #2628: Create upgrade path from 4.9.3.1 to 4.11.1.0

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #2628: Create upgrade path from 4.9.3.1 to 4.11.1.0
URL: https://github.com/apache/cloudstack/pull/2628#discussion_r186417684
 
 

 ##########
 File path: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java
 ##########
 @@ -408,6 +408,9 @@ public DatabaseUpgradeChecker() {
         _upgradeMap.put(CloudStackVersion.parse("4.9.3.0"),
             new DbUpgrade[] {new Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41110()});
 
+        _upgradeMap.put(CloudStackVersion.parse("4.9.3.1"),
+                new DbUpgrade[] {new Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41110()});
 
 Review comment:
   This is fine, the security release the 4th dot number (a.b.c.x, the `x`) is considered to NOT usually have any db path/upgrade change, which is why we introduced it in the past. The change is acceptable, not requiring tests if manually @rafaelweingartner or someone else can confirm the change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services