You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/02/13 08:29:02 UTC
[GitHub] [submarine] kobe860219 opened a new pull request #513: SUBMARINE-737. Fix router link in e2e test
kobe860219 opened a new pull request #513:
URL: https://github.com/apache/submarine/pull/513
### What is this PR for?
SUBMARINE-729 fix the blank page after redirect, so should fix e2e test about testing router link.
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-737
### How should this be tested?
https://travis-ci.org/github/kobe860219/submarine/builds/758805284
### Screenshots (if appropriate)
<img width="861" alt="截圖 2021-02-13 下午4 17 52" src="https://user-images.githubusercontent.com/48027290/107845694-766c1f80-6e18-11eb-8097-30e6c88b63da.png">
<img width="900" alt="截圖 2021-02-13 下午4 23 45" src="https://user-images.githubusercontent.com/48027290/107845695-79ffa680-6e18-11eb-8b36-2802fbf09760.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on pull request #513: SUBMARINE-737. Fix router link in e2e test
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #513:
URL: https://github.com/apache/submarine/pull/513#issuecomment-778623626
Hi @kobe860219. The Travis tests still fail, could you take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kobe860219 commented on pull request #513: SUBMARINE-737. Fix router link in e2e test
Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #513:
URL: https://github.com/apache/submarine/pull/513#issuecomment-778738294
@pingsutw In my travis, now e2e-test is success. Thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #513: SUBMARINE-737. Fix router link in e2e test
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #513:
URL: https://github.com/apache/submarine/pull/513
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kobe860219 commented on pull request #513: SUBMARINE-737. Fix router link in e2e test
Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #513:
URL: https://github.com/apache/submarine/pull/513#issuecomment-778583606
@pingsutw This PR fix the problem in travis's tests which caused by SUBMARINE-729.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kobe860219 edited a comment on pull request #513: SUBMARINE-737. Fix router link in e2e test
Posted by GitBox <gi...@apache.org>.
kobe860219 edited a comment on pull request #513:
URL: https://github.com/apache/submarine/pull/513#issuecomment-778738294
@pingsutw I fix it in newest commit. Now in my travis, e2e-test is success. Thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org