[GitHub] [hbase] ramkrish86 commented on a change in pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

[GitBox <gi...@apache.org>]

ramkrish86 commented on a change in pull request #2483:
URL: https://github.com/apache/hbase/pull/2483#discussion_r521518340



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -3481,6 +3512,9 @@ public ScanResponse scan(final RpcController controller, final ScanRequest reque
       }
       throw new ServiceException(e);
     }
+    if(rsh.isFullRegionScan) {
+      rpcFullScanRequestCount.increment();

Review comment:
       Ya this looks good. So this is happening only for scan na ? 

##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -3167,7 +3187,18 @@ private RegionScannerHolder newRegionScanner(ScanRequest request, ScanResponse.B
     builder.setMvccReadPoint(scanner.getMvccReadPoint());
     builder.setTtl(scannerLeaseTimeoutPeriod);
     String scannerName = String.valueOf(scannerId);
-    return addScanner(scannerName, scanner, shipper, region, scan.isNeedCursorResult());
+
+    boolean isFullRegionScan = false;
+    if(!region.getRegionInfo().getTable().isSystemTable()) {
+      if(checkFullRegionScan(scan, region)){
+        isFullRegionScan = true;
+      } else {
+        isFullRegionScan = false;
+      }
+    } else {
+      isFullRegionScan = false;

Review comment:
       This might not be needed. anyway we have inited to false na.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org