You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/23 06:58:28 UTC
[GitHub] [cordova-android] erisu opened a new pull request #1005: chore: set AndroidX off by default
erisu opened a new pull request #1005:
URL: https://github.com/apache/cordova-android/pull/1005
### Motivation, Context & Description
* User plugins are most likely not ready to support AndroidX.
* Users are most likely not be aware of the AndroidX support roadmap and that this major would have been enabled by default but instead to be pushed back for next major.
### Testing
- `npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1005: chore: set AndroidX off by default
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1005:
URL: https://github.com/apache/cordova-android/pull/1005#issuecomment-647950234
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1005?src=pr&el=h1) Report
> Merging [#1005](https://codecov.io/gh/apache/cordova-android/pull/1005?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/d90e19183779b109db8591982092c053d19ca361&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1005?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1005 +/- ##
==========================================
- Coverage 68.09% 68.04% -0.06%
==========================================
Files 21 21
Lines 1868 1868
==========================================
- Hits 1272 1271 -1
- Misses 596 597 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1005?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...lates/cordova/lib/config/GradlePropertiesParser.js](https://codecov.io/gh/apache/cordova-android/pull/1005/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jb25maWcvR3JhZGxlUHJvcGVydGllc1BhcnNlci5qcw==) | `86.27% <ø> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1005/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.06% <0.00%> (-0.47%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1005?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1005?src=pr&el=footer). Last update [d90e191...d81f46d](https://codecov.io/gh/apache/cordova-android/pull/1005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1005: chore: set AndroidX off by default
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1005:
URL: https://github.com/apache/cordova-android/pull/1005#issuecomment-647950234
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1005?src=pr&el=h1) Report
> Merging [#1005](https://codecov.io/gh/apache/cordova-android/pull/1005?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/d90e19183779b109db8591982092c053d19ca361&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1005?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1005 +/- ##
==========================================
- Coverage 68.09% 68.04% -0.06%
==========================================
Files 21 21
Lines 1868 1868
==========================================
- Hits 1272 1271 -1
- Misses 596 597 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1005?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...lates/cordova/lib/config/GradlePropertiesParser.js](https://codecov.io/gh/apache/cordova-android/pull/1005/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jb25maWcvR3JhZGxlUHJvcGVydGllc1BhcnNlci5qcw==) | `86.27% <ø> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1005/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.06% <0.00%> (-0.47%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1005?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1005?src=pr&el=footer). Last update [d90e191...d81f46d](https://codecov.io/gh/apache/cordova-android/pull/1005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #1005: chore: set AndroidX off by default
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1005:
URL: https://github.com/apache/cordova-android/pull/1005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org