You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/04/13 01:02:18 UTC
[Impala-ASF-CR] IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13006
Change subject: IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
......................................................................
IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
---
M docs/topics/impala_explain_plan.xml
1 file changed, 22 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/13006/1
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13006 )
Change subject: IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/307/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Apr 2019 21:53:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13006 )
Change subject: IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
......................................................................
Patch Set 1:
Lars,
Could you please review this patch? Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 22:26:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13006 )
Change subject: IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/306/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 13 Apr 2019 01:02:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7892 IMPALA-8416: [DOCS] Described the new network and disk info in query profiles
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13006
to look at the new patch set (#3).
Change subject: IMPALA-7892 IMPALA-8416: [DOCS] Described the new network and disk info in query profiles
......................................................................
IMPALA-7892 IMPALA-8416: [DOCS] Described the new network and disk info in query profiles
- HostDiskReadThroughput
- HostDiskWriteThroughput
- HostNetworkRx
- HostNetworkTx
Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
---
M docs/topics/impala_explain_plan.xml
1 file changed, 30 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/13006/3
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13006 )
Change subject: IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/307/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Apr 2019 21:31:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7892 IMPALA-8416: [DOCS] Described the new network and disk info in query profiles
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13006 )
Change subject: IMPALA-7892 IMPALA-8416: [DOCS] Described the new network and disk info in query profiles
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 May 2019 17:11:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13006 )
Change subject: IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13006/1/docs/topics/impala_explain_plan.xml
File docs/topics/impala_explain_plan.xml:
http://gerrit.cloudera.org:8080/#/c/13006/1/docs/topics/impala_explain_plan.xml@238
PS1, Line 238: and other processes
: running on the same system.
This does not include processes on the same system (we exclude the loopback interface when aggregating the network counters). It only includes traffic to/from other hosts.
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 19:18:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7892 IMPALA-8416: [DOCS] Described the new network and disk info in query profiles
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13006 )
Change subject: IMPALA-7892 IMPALA-8416: [DOCS] Described the new network and disk info in query profiles
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/308/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Apr 2019 00:20:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7892 IMPALA-8416: [DOCS] Described the new network and disk info in query profiles
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13006 )
Change subject: IMPALA-7892 IMPALA-8416: [DOCS] Described the new network and disk info in query profiles
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/308/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Apr 2019 00:26:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13006
to look at the new patch set (#2).
Change subject: IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
......................................................................
IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
---
M docs/topics/impala_explain_plan.xml
1 file changed, 21 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/13006/2
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13006 )
Change subject: IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13006/1/docs/topics/impala_explain_plan.xml
File docs/topics/impala_explain_plan.xml:
http://gerrit.cloudera.org:8080/#/c/13006/1/docs/topics/impala_explain_plan.xml@238
PS1, Line 238: and other processes
: running on the same system.
> This does not include processes on the same system (we exclude the loopback
Done
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Apr 2019 21:31:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13006 )
Change subject: IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/306/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Sat, 13 Apr 2019 01:14:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7892 IMPALA-8416: [DOCS] Described the new network and disk info in query profiles
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13006 )
Change subject: IMPALA-7892 IMPALA-8416: [DOCS] Described the new network and disk info in query profiles
......................................................................
IMPALA-7892 IMPALA-8416: [DOCS] Described the new network and disk info in query profiles
- HostDiskReadThroughput
- HostDiskWriteThroughput
- HostNetworkRx
- HostNetworkTx
Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Reviewed-on: http://gerrit.cloudera.org:8080/13006
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Lars Volker <lv...@cloudera.com>
---
M docs/topics/impala_explain_plan.xml
1 file changed, 30 insertions(+), 13 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Lars Volker: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13006 )
Change subject: IMPALA-7892: [DOCS] Described the new network I/O throughput in query profiles
......................................................................
Patch Set 2:
Lars,
Could you take a look at the new patch? Thank you!
--
To view, visit http://gerrit.cloudera.org:8080/13006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25b128bc23f418347b400ca9e694d9d591935592
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 20:55:43 +0000
Gerrit-HasComments: No