[GitHub] [fineract] galovics commented on a diff in pull request #2363: FINERACT-1641: Invalid Date of transaction after reversal correction

[GitBox <gi...@apache.org>]

galovics commented on code in PR #2363:
URL: https://github.com/apache/fineract/pull/2363#discussion_r897629070


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountTransaction.java:
##########
@@ -304,8 +304,8 @@ public static void updateTaxDetails(final Map<TaxComponent, BigDecimal> taxDetai
 
     public static SavingsAccountTransaction copyTransaction(SavingsAccountTransaction accountTransaction) {
         return new SavingsAccountTransaction(accountTransaction.savingsAccount, accountTransaction.office, accountTransaction.paymentDetail,
-                accountTransaction.typeOf, accountTransaction.transactionLocalDate(), accountTransaction.createdDate,
-                accountTransaction.amount, accountTransaction.reversed, accountTransaction.appUser, accountTransaction.isManualTransaction,
+                accountTransaction.typeOf, accountTransaction.transactionLocalDate(), new Date(), accountTransaction.amount,

Review Comment:
   Rather should be `DateUtils#getLocalDateOfTenant` IMO.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org