You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2015/03/02 23:14:11 UTC
Review Request 31642: SQOOP-2162: Sqoop2: InputEditable should be
optional in JSON API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31642/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2162
https://issues.apache.org/jira/browse/SQOOP-2162
Repository: sqoop-sqoop2
Description
-------
commit dd49cba2e8683ede27a325c0c223d25011935e89
Author: Abraham Elmahrek <ab...@apache.org>
Date: Mon Mar 2 13:56:17 2015 -0800
SQOOP-2162: Sqoop2: InputEditable should be optional in JSON API
:100644 100644 ffaf041... 1b1ec28... M common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java
:100644 100644 f7f45f9... 368502f... M common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java
Diffs
-----
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java ffaf041
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java f7f45f9
Diff: https://reviews.apache.org/r/31642/diff/
Testing
-------
mvn test.
Manually test through Hue.
Thanks,
Abraham Elmahrek
Re: Review Request 31642: SQOOP-2162: Sqoop2: InputEditable should be
optional in JSON API
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31642/#review74871
-----------------------------------------------------------
Ship it!
LGTM
- richard zhou
On March 2, 2015, 10:14 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31642/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 10:14 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2162
> https://issues.apache.org/jira/browse/SQOOP-2162
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit dd49cba2e8683ede27a325c0c223d25011935e89
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Mon Mar 2 13:56:17 2015 -0800
>
> SQOOP-2162: Sqoop2: InputEditable should be optional in JSON API
>
> :100644 100644 ffaf041... 1b1ec28... M common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java
> :100644 100644 f7f45f9... 368502f... M common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java ffaf041
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java f7f45f9
>
> Diff: https://reviews.apache.org/r/31642/diff/
>
>
> Testing
> -------
>
> mvn test.
> Manually test through Hue.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>