You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/27 09:31:09 UTC
[GitHub] [flink-table-store] tsreaper opened a new pull request, #142: [FLINK-27814] Add an abstraction layer for connectors to read and write row data instead of key-values
tsreaper opened a new pull request, #142:
URL: https://github.com/apache/flink-table-store/pull/142
Currently `FileStore` exposes an interface for reading and writing `KeyValue`. However connectors may have different ways to change a `RowData` to `KeyValue` under different `WriteMode`. This results in lots of `if...else...` branches and duplicated code.
We need to add an abstraction layer for connectors to read and write row data instead of key-values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on pull request #142: [FLINK-27814] Add an abstraction layer for connectors to read and write row data instead of key-values
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on PR #142:
URL: https://github.com/apache/flink-table-store/pull/142#issuecomment-1140251177
I think the first thing we can do is:
We can start with a design document in PR comments which gives a general description of the APIs that the Hive connector needs to use. These APIs should be relatively public, they don't necessarily need to be marked as Public, but we need to make sure that these APIs are simple enough to make the future connectors as simple as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on pull request #142: [FLINK-27814] Add an abstraction layer for connectors to read and write row data instead of key-values
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on PR #142:
URL: https://github.com/apache/flink-table-store/pull/142#issuecomment-1140250702
Thanks @tsreaper for the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] tsreaper closed pull request #142: [FLINK-27814] Add an abstraction layer for connectors to read and write row data instead of key-values
Posted by GitBox <gi...@apache.org>.
tsreaper closed pull request #142: [FLINK-27814] Add an abstraction layer for connectors to read and write row data instead of key-values
URL: https://github.com/apache/flink-table-store/pull/142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org