You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/05/25 07:49:10 UTC
[GitHub] [incubator-inlong] TszKitLo40 opened a new pull request #474: [INLONG-619]Configuration for Go SDK.
TszKitLo40 opened a new pull request #474:
URL: https://github.com/apache/incubator-inlong/pull/474
Signed-off-by: Zijie Lu <ws...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] charlely commented on a change in pull request #474: [INLONG-619]Configuration for Go SDK.
Posted by GitBox <gi...@apache.org>.
charlely commented on a change in pull request #474:
URL: https://github.com/apache/incubator-inlong/pull/474#discussion_r638546532
##########
File path: tubemq-client-twins/tubemq-client-go/config/config.go
##########
@@ -19,14 +19,184 @@
package config
import (
+ "fmt"
+ "net/url"
+ "strconv"
+ "strings"
"time"
)
// Config defines multiple configuration options.
type Config struct {
- // Net iis the namespace for network-level properties used by Broker and Master.
+ // Net is the namespace for network-level properties used by Broker and Master.
Net struct {
// How long to wait for a response.
ReadTimeout time.Duration
+ // TLS based authentication with broker and master.
+ TLS struct {
+ // Whether or not to use TLS.
+ Enable bool
+ // CACertFile for TLS.
+ CACertFile string
+ // TLSCertFile for TLS.
+ TLSCertFile string
+ // TLSKeyFile for TLS.
+ TLSKeyFile string
+ // TTSServerName for TLS.
+ TLSServerName string
+ }
}
+
+ // Consumer is the namespace for configuration related to consume messages,
+ // used by the consumer
+ Consumer struct {
Review comment:
Need to add a note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] TszKitLo40 commented on pull request #474: [INLONG-619]Configuration for Go SDK.
Posted by GitBox <gi...@apache.org>.
TszKitLo40 commented on pull request #474:
URL: https://github.com/apache/incubator-inlong/pull/474#issuecomment-847636287
@gosonzhang @charlely PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gosonzhang merged pull request #474: [INLONG-619]Configuration for Go SDK.
Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #474:
URL: https://github.com/apache/incubator-inlong/pull/474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] charlely commented on a change in pull request #474: [INLONG-619]Configuration for Go SDK.
Posted by GitBox <gi...@apache.org>.
charlely commented on a change in pull request #474:
URL: https://github.com/apache/incubator-inlong/pull/474#discussion_r638546005
##########
File path: tubemq-client-twins/tubemq-client-go/config/config.go
##########
@@ -19,14 +19,184 @@
package config
import (
+ "fmt"
+ "net/url"
+ "strconv"
+ "strings"
"time"
)
// Config defines multiple configuration options.
type Config struct {
- // Net iis the namespace for network-level properties used by Broker and Master.
+ // Net is the namespace for network-level properties used by Broker and Master.
Net struct {
// How long to wait for a response.
ReadTimeout time.Duration
+ // TLS based authentication with broker and master.
+ TLS struct {
+ // Whether or not to use TLS.
+ Enable bool
+ // CACertFile for TLS.
+ CACertFile string
+ // TLSCertFile for TLS.
+ TLSCertFile string
+ // TLSKeyFile for TLS.
+ TLSKeyFile string
+ // TTSServerName for TLS.
+ TLSServerName string
+ }
}
+
+ // Consumer is the namespace for configuration related to consume messages,
+ // used by the consumer
+ Consumer struct {
+ masters []string
Review comment:
How do external packages use these non-exported parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #474: [INLONG-619]Configuration for Go SDK.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #474:
URL: https://github.com/apache/incubator-inlong/pull/474#issuecomment-848403887
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/474?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#474](https://codecov.io/gh/apache/incubator-inlong/pull/474?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a57aa8) into [INLONG-25](https://codecov.io/gh/apache/incubator-inlong/commit/ddfab69aa7ed27c9b3b46c49338a87030349f245?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ddfab69) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## INLONG-25 #474 +/- ##
==============================================
- Coverage 7.51% 7.48% -0.03%
Complexity 479 479
==============================================
Files 267 267
Lines 29500 29500
Branches 4843 4843
==============================================
- Hits 2216 2209 -7
- Misses 26810 26816 +6
- Partials 474 475 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/flume/sink/tubemq/TubemqSink.java](https://codecov.io/gh/apache/incubator-inlong/pull/474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLWNvbm5lY3RvcnMvdHViZW1xLWNvbm5lY3Rvci1mbHVtZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZmx1bWUvc2luay90dWJlbXEvVHViZW1xU2luay5qYXZh) | `51.42% <0.00%> (-4.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/474?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/474?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ddfab69...8a57aa8](https://codecov.io/gh/apache/incubator-inlong/pull/474?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter edited a comment on pull request #474: [INLONG-619]Configuration for Go SDK.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #474:
URL: https://github.com/apache/incubator-inlong/pull/474#issuecomment-848403887
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/474?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#474](https://codecov.io/gh/apache/incubator-inlong/pull/474?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d6f664) into [INLONG-25](https://codecov.io/gh/apache/incubator-inlong/commit/ddfab69aa7ed27c9b3b46c49338a87030349f245?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ddfab69) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## INLONG-25 #474 +/- ##
===========================================
Coverage 7.51% 7.51%
Complexity 479 479
===========================================
Files 267 267
Lines 29500 29500
Branches 4843 4843
===========================================
Hits 2216 2216
Misses 26810 26810
Partials 474 474
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/474?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/474?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ddfab69...7d6f664](https://codecov.io/gh/apache/incubator-inlong/pull/474?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gosonzhang commented on pull request #474: [INLONG-619]Configuration for Go SDK.
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on pull request #474:
URL: https://github.com/apache/incubator-inlong/pull/474#issuecomment-849401062
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org