[GitHub] [kafka] jolshan commented on a diff in pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

["jolshan (via GitHub)" <gi...@apache.org>]

jolshan commented on code in PR #13078:
URL: https://github.com/apache/kafka/pull/13078#discussion_r1104718447


##########
core/src/main/scala/kafka/log/ProducerStateManager.scala:
##########
@@ -504,7 +520,7 @@ class ProducerStateManager(
    * Truncate the producer id mapping and remove all snapshots. This resets the state of the mapping.
    */
   def truncateFullyAndStartAt(offset: Long): Unit = {
-    producers.clear()
+    removeProducerIds(producers.keySet)

Review Comment:
   I asked Anastasia about this offline and she said the clear method also removes all the keys (using the -= operator for each one)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org