You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/04 11:48:18 UTC
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15621: [chore](vulnerability) fix some high risk vulnerabilities report by bug scanner
github-actions[bot] commented on code in PR #15621:
URL: https://github.com/apache/doris/pull/15621#discussion_r1061402003
##########
be/src/vec/exec/vmysql_scan_node.cpp:
##########
@@ -146,11 +145,15 @@
}
Status VMysqlScanNode::get_next(RuntimeState* state, vectorized::Block* block, bool* eos) {
+ if (state == NULL || block == NULL || eos == NULL) {
Review Comment:
warning: use nullptr [modernize-use-nullptr]
```suggestion
if (state == NULL || block == nullptr || eos == NULL) {
```
##########
be/src/vec/exec/vmysql_scan_node.cpp:
##########
@@ -146,11 +145,15 @@
}
Status VMysqlScanNode::get_next(RuntimeState* state, vectorized::Block* block, bool* eos) {
+ if (state == NULL || block == NULL || eos == NULL) {
Review Comment:
warning: use nullptr [modernize-use-nullptr]
```suggestion
if (state == NULL || block == NULL || eos == nullptr) {
```
##########
be/src/vec/exec/vmysql_scan_node.cpp:
##########
@@ -146,11 +145,15 @@ Status VMysqlScanNode::write_text_slot(char* value, int value_length, SlotDescri
}
Status VMysqlScanNode::get_next(RuntimeState* state, vectorized::Block* block, bool* eos) {
+ if (state == NULL || block == NULL || eos == NULL) {
Review Comment:
warning: use nullptr [modernize-use-nullptr]
```suggestion
if (state == nullptr || block == NULL || eos == NULL) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org